Conversation
|
|
|
Thank you for your contribution. I need to change the base reference branch where you are contributing from master to develop. The master branch is reserved for stable code in production. |
RDCH106
left a comment
RDCH106
left a comment
There was a problem hiding this comment.
After a first review, I left some comments that I hope to clarify with you.
| self.__submodule_path_pattern = re.compile('path ?= ?([A-za-z0-9-_]+)(\\/[A-za-z0-9-_]+)*([A-za-z0-9-_])') | ||
| self.__path_pattern = re.compile(' ([A-za-z0-9-_]+)(\\/[A-za-z0-9-_]+)*([A-za-z0-9-_])') |
There was a problem hiding this comment.
What kind of problems did you have to make this change?
There was a problem hiding this comment.
Actually this is a unrelated change. When I was testing the new feature I noticed a warning complaining about a malformed regular expression, something like unrecognized escape sequence. Either it was missing a backslash or it had one extra. I decided that it was missing one so it's able to parse windows paths.
It could go in a different PR if you wish.
parallelforeachsubmodule/pfs.py
Outdated
| # type=self.empty_cmd, | ||
| default="") | ||
| parser.add_argument('--filter', dest='filter_branch', | ||
| help='Execute this command only in modules that have an specific branch.') |
There was a problem hiding this comment.
Remove . at the end of the help to preserve the style with the other helps
3 participants
Add a "--filter " option to execute an action only in modules that are in the specified branch.