♻️ Refactor PDF processing code to align with PDFium thread-safety and rendering best practices#1209
Open
balazs-szucs wants to merge 15 commits into
Open
♻️ Refactor PDF processing code to align with PDFium thread-safety and rendering best practices#1209balazs-szucs wants to merge 15 commits into
balazs-szucs wants to merge 15 commits into
Conversation
…e operations and pre-rendering logic
aaronleopold
reviewed
Jun 5, 2026
aaronleopold
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for starting this! I had a few comments to sort out but nothing major
Collaborator
|
I haven't had much Stump time this week unfortunately, but I've pushed a few changes based on our discussions and will aim to give a final review by the weekend to get this into nightly. Thanks again for getting the ball rolling here, and sorry for how delayed getting it in has been! |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the last point, generally, PDFIum should be much more reliable/performant than from what I can moreso a hobbyist Rust PDF library. So, using PDF.rs then to fallback PDFium, that seemed like bit of strange choice, and when I flipped them, i thought, there is very unlikely that PDFium would fail and PDF.rs would catch it, so at that point better to just remove. PDF.rs was also pulling in seemingly quite large of other deps. So, I think that's a win.
Date parsing still hacky. But it is mostly in working condition.
I am still not happy with date stuff, but otherwise this should be improvements. It's able parse in the bit more metadata (e.g., Summary/Description that was previously ignored), i have not been able to trigger segfault, but yeah bit slower overall (not a huge surprise.)