fix(buddies): show Add New Buddy screen in front of the bulk-edit dialog#708
Open
mgoodness wants to merge 1 commit into
Open
fix(buddies): show Add New Buddy screen in front of the bulk-edit dialog#708mgoodness wants to merge 1 commit into
mgoodness wants to merge 1 commit into
Conversation
Bulk-editing dives opens the buddy picker inside a showDialog (root navigator by default); the buddy-selection bottom sheet resolves to that same root navigator. The newBuddy route, however, is nested under the app's ShellRoute with no parentNavigatorKey override, so it mounted on the shell's own nested navigator instead -- rendering underneath the still-open dialog/sheet on the root navigator. Users had to back out of both to find the new-buddy screen was open the whole time. Give newBuddy a parentNavigatorKey pointing at the root navigator so it always escapes to wherever the dialog/sheet actually are. Fixes submersion-app#707 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
📦 Build artifacts for this PR · commit
Artifacts expire in 7 days. Downloading requires being signed in to GitHub. The macOS build is ad-hoc signed — right-click → Open on first launch. Updated automatically on each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bulk-editing dives opens the buddy picker inside a
showDialog(root navigator by default); the buddy-selection bottom sheet resolves to that same root navigator. ThenewBuddyroute, however, is nested under the app'sShellRoutewith noparentNavigatorKeyoverride, so it mounted on the shell's own nested navigator instead -- rendering underneath the still-open dialog/sheet on the root navigator. Users had to back out of both to find the new-buddy screen was open the whole time.Type of Change
Changes Made
newBuddyGoRoute aparentNavigatorKeypointing at the root navigator so it always escapes to wherever the dialog/sheet actually arenewBuddy'sparentNavigatorKeyBuddyPicker+BuddyEditPagethrough the bulk-edit dialog flow, confirming the new screen renders on top and the dialog/sheet correctly reappear (with state intact) once saved and popped; also covers the single-dive-edit (no-dialog) flow to confirm no regressionTesting
Checklist
flutter analyzeScreenshots
N/A
Related Issues
Fixes #707