fix(dive-centers): include state/province in location display - #711
Merged
ericgriffin merged 2 commits intoJul 28, 2026
Merged
Conversation
mgoodness
added a commit
to mgoodness/submersion
that referenced
this pull request
Jul 24, 2026
Added as a sibling section to Pull Request Descriptions, not folded into it, to avoid upstream merge conflicts. Discovered via PR submersion-app#711, whose first draft merged sections, substituted checkboxes, and dropped the Screenshots heading.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
📦 Build artifacts for this PR · commit
Artifacts expire in 7 days. Downloading requires being signed in to GitHub. The macOS build is ad-hoc signed — right-click → Open on first launch. Updated automatically on each push. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes dive center location rendering by updating the domain-level DiveCenter.fullLocationString getter to include stateProvince between city and country when present, aligning the displayed location across list tiles, detail views, and map UI that rely on this getter.
Changes:
- Updated
DiveCenter.fullLocationStringto includestateProvincewhen available. - Added unit tests covering the city/state/country combinations for
fullLocationString.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/features/dive_centers/domain/entities/dive_center.dart | Includes stateProvince in fullLocationString so location displays no longer drop it. |
| test/features/dive_centers/domain/entities/dive_center_test.dart | Adds coverage for fullLocationString formatting with/without stateProvince and city. |
mgoodness
added a commit
to mgoodness/submersion
that referenced
this pull request
Jul 27, 2026
fullLocationString now covers the same fields and join logic; addressSummary had no callers anywhere in the codebase. Addresses Copilot review feedback on PR submersion-app#711.
DiveCenter.fullLocationString only joined city and country, silently dropping state/province even when set. This getter backs every dive-center location display (list tiles, detail page, map view, summary widget). Fixes submersion-app#710
fullLocationString now covers the same fields and join logic; addressSummary had no callers anywhere in the codebase. Addresses Copilot review feedback on PR submersion-app#711.
mgoodness
force-pushed
the
dive-center-partial-location
branch
from
July 27, 2026 15:14
65e7d0b to
028476b
Compare
github-project-automation
Bot
moved this from In review
to Done
in Submersion Release Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dive center location displays (list tiles, detail page, map view, summary widget) only showed city and country, silently dropping state/province even when it was set. Fixes #710.
Changes
DiveCenter.fullLocationStringnow includesstateProvincebetween city and country whenever it's present.Test Plan
flutter testpassesflutter analyzepassesScreenshots
Text-only change (no layout/visual change) — see #710 for the before/after location strings.