Conversation
danielledeleo
changed the base branch from
main
to
connor/replace-coordinator
danielledeleo
force-pushed
the
jagger/e2-cli
branch
from
9314200 to
83bafc0
Compare
danielledeleo
force-pushed
the
jagger/e2-cli
branch
from
83bafc0 to
efac1cc
Compare
cohix
reviewed
Dec 14, 2022
| util.LogInfo("Services:") | ||
| util.Command.Run("kubectl get svc -n suborbital") | ||
|
|
||
| return nil |
Contributor
There was a problem hiding this comment.
Let's also try starting up the kubectl proxy and pinging the e2core health endpoint to make sure it's actually started and serving?
Contributor
There was a problem hiding this comment.
I think we'd just pull metadata from Kubernetes itself to ensure the services are healthy
Contributor
There was a problem hiding this comment.
I'll make some changes to the templates to support this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a first crack at a much smaller replacement for subo, called e2.
The main change from subo is that it pulls templates from the e2core repo (not suborbital/templates) at the tag it was released at, unless told otherwise.
Testing:
The branch flag is necessary because the current release doesn't contain the templates.