fix: use dynamic admin URL generation instead of hardcoded path#296
Open
chrismshea wants to merge 1 commit intosubscribepro:mainfrom
Open
fix: use dynamic admin URL generation instead of hardcoded path#296chrismshea wants to merge 1 commit intosubscribepro:mainfrom
chrismshea wants to merge 1 commit intosubscribepro:mainfrom
Conversation
Replace hardcoded admin URL path with Magento's BackendUrlInterface to properly support merchants with custom admin paths configured.
- Remove ADMIN_ORDER_AMOUNT_URL constant
- Inject \Magento\Backend\Model\UrlInterface via constructor
- Use $backendUrl->getUrl('subscribepro/order/amount') to generate dynamically
- Ensures compatibility with custom admin path configurations
chrismshea
force-pushed
the
295-custom-admin-url-issue
branch
from
9938926 to
435c19f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded admin URL path with Magento's BackendUrlInterface to properly support merchants with custom admin paths configured.