fix(picker): use index-based item matching in fzf-lua#283
Merged
sudo-tee merged 1 commit intosudo-tee:mainfrom Feb 17, 2026
Merged
fix(picker): use index-based item matching in fzf-lua#283sudo-tee merged 1 commit intosudo-tee:mainfrom
sudo-tee merged 1 commit intosudo-tee:mainfrom
Conversation
Owner
|
Thanks for the fix :) As I don't use fzf_lua myself, I test it less frequently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting, deleting, or renaming child sessions in the fzf-lua picker did nothing, the picker just closed silently.
The issue was in
fn_fzf_indexwhich matched selected fzf lines back to items using string comparison. This broke for child sessions due to formatting/whitespace mismatches between what fzf returns and whatto_string()produces.