-
Notifications
You must be signed in to change notification settings - Fork 44
Review #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Review #6
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,5 +1,3 @@ | ||||||
| import 'dart:developer'; | ||||||
|
|
||||||
| import 'package:flutter/material.dart'; | ||||||
| import 'package:intl/intl.dart'; | ||||||
|
|
||||||
|
|
@@ -20,16 +18,11 @@ class MyApp extends StatelessWidget { | |||||
| title: 'FlutterDevcamp - 2022 - Welcome', | ||||||
| theme: ThemeData( | ||||||
| primaryColor: AppConstants.hexToColor(AppConstants.appPrimaryColor), | ||||||
| backgroundColor: | ||||||
| AppConstants.hexToColor(AppConstants.appBackgroundColor), | ||||||
| primaryColorLight: | ||||||
| AppConstants.hexToColor(AppConstants.appPrimaryColorLight), | ||||||
| dividerColor: | ||||||
| AppConstants.hexToColor(AppConstants.appBackgroundColorGray), | ||||||
| backgroundColor: AppConstants.hexToColor(AppConstants.appBackgroundColor), | ||||||
| primaryColorLight: AppConstants.hexToColor(AppConstants.appPrimaryColorLight), | ||||||
| dividerColor: AppConstants.hexToColor(AppConstants.appBackgroundColorGray), | ||||||
|
Comment on lines
+21
to
+23
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. dont need this part
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FGHHFGDH |
||||||
| textTheme: TextTheme( | ||||||
| caption: TextStyle( | ||||||
| color: AppConstants.hexToColor( | ||||||
| AppConstants.appPrimaryFontColorWhite)), | ||||||
| caption: TextStyle(color: AppConstants.hexToColor(AppConstants.appPrimaryFontColorWhite)), | ||||||
| ), | ||||||
| ), | ||||||
| home: const MyHomePage(title: 'FlutterDevcamp - 2022 - Welcome'), | ||||||
|
|
@@ -49,14 +42,15 @@ class MyHomePage extends StatefulWidget { | |||||
| class _MyHomePageState extends State<MyHomePage> { | ||||||
| int _counter = 1; | ||||||
| final nameController = TextEditingController(); | ||||||
| String name = ""; | ||||||
| String name = "Marius"; | ||||||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| var currentDay = DateTime.now().day; | ||||||
| void _printLatestValue() { | ||||||
| setState(() { | ||||||
| name = nameController.text; | ||||||
| }); | ||||||
| } | ||||||
|
|
||||||
| var e = 4; | ||||||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just a change request |
||||||
| @override | ||||||
| void initState() { | ||||||
| super.initState(); | ||||||
|
|
@@ -68,11 +62,6 @@ class _MyHomePageState extends State<MyHomePage> { | |||||
| void _incrementCounter() { | ||||||
| setState(() { | ||||||
| (currentDay < _counter) ? _counter = 1 : _counter++; | ||||||
| // This call to setState tells the Flutter framework that something has | ||||||
| // changed in this State, which causes it to rerun the build method below | ||||||
| // so that the display can reflect the updated values. If we changed | ||||||
| // _counter without calling setState(), then the build method would not be | ||||||
| // called again, and so nothing would appear to happen. | ||||||
| }); | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -88,6 +77,8 @@ class _MyHomePageState extends State<MyHomePage> { | |||||
| return Scaffold( | ||||||
| resizeToAvoidBottomInset: false, | ||||||
| appBar: AppBar( | ||||||
| elevation: 4, | ||||||
| backgroundColor: Colors.red, | ||||||
|
Comment on lines
+80
to
+81
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MULTIPLE SELECT |
||||||
| title: Text(widget.title), | ||||||
| ), | ||||||
| body: Column( | ||||||
|
|
@@ -111,8 +102,7 @@ class _MyHomePageState extends State<MyHomePage> { | |||||
| child: Text( | ||||||
| '#flutterdevcamp - London ${DateFormat.MMMMd().format(DateTime.now())} ', | ||||||
| style: TextStyle( | ||||||
| color: AppConstants.hexToColor( | ||||||
| AppConstants.appPrimaryColorLight), | ||||||
| color: AppConstants.hexToColor(AppConstants.appPrimaryColorLight), | ||||||
| fontSize: 24, | ||||||
| fontWeight: FontWeight.w600, | ||||||
| ), | ||||||
|
|
@@ -129,6 +119,10 @@ class _MyHomePageState extends State<MyHomePage> { | |||||
| currentDay == _counter ? "🪙" : "$_counter times ", | ||||||
| style: Theme.of(context).textTheme.headline2, | ||||||
| ), | ||||||
| Text( | ||||||
| currentDay == _counter ? "🪙" : "$_counter times de review ", | ||||||
| style: Theme.of(context).textTheme.headline2, | ||||||
| ), | ||||||
|
Comment on lines
+122
to
+125
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MULTI LINE SELECTION COMMENT |
||||||
| Padding( | ||||||
| padding: const EdgeInsets.all(8.0), | ||||||
| child: TextField( | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DGFSDFS