Fix password_strength_checker_controller.js strength classes

[daphneslootmans]

Summary by Sourcery

Bug Fixes:

• Correct password strength class mapping so the highest strength level uses 'very-strong' instead of reusing intermediate classes.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the password strength meter’s CSS class mapping so that the third strength level is treated as medium and only higher levels are mapped to strong/very-strong.

Flow diagram for password strength value to CSS class mapping

flowchart LR
  A[Compute_password_strength 0_to_4] --> B{strength_value}

  B -->|0| C[Apply_CSS_class_weak]
  B -->|1| D[Apply_CSS_class_medium]
  B -->|2| E[Apply_CSS_class_medium]
  B -->|3| F[Apply_CSS_class_strong]
  B -->|4| G[Apply_CSS_class_very_strong]

Loading

File-Level Changes

Change	Details	Files
Correct password strength level-to-class mapping for the UI meter.	Update the strength-to-class array so the third strength bucket maps to the 'medium' class instead of 'strong' Preserve the existing five-level structure of the meter while rebalancing which levels are considered strong vs very-strong	assets-public/controllers/password_strength_checker_controller.js

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider validating or clamping the strength index (or documenting its expected range) so that changes to the strength scoring logic in the future don’t accidentally access outside the classes array.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider validating or clamping the `strength` index (or documenting its expected range) so that changes to the strength scoring logic in the future don’t accidentally access outside the `classes` array.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}