Retype distortion models to SpectralPositionalVectorArray#156
Merged
Conversation
Make `AbstractDistortionModel.distort`/`undistort` accept and return `na.SpectralPositionalVectorArray` instead of `optika.vectors.SceneVectorArray`, so the scene and sensor coordinates share one named-arrays vector type. `PolynomialDistortionModel` now feeds `coordinates_scene` directly into the fit (the scene vector already exposes `wavelength`/`position` as polynomial components), and `undistort` returns a `SpectralPositionalVectorArray`. This also lets downstream consumers (e.g. `AbstractInterpolatedSystem`, and `ctis` instruments) call the model without repackaging coordinates. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 99.29% 99.29% -0.01%
==========================================
Files 111 111
Lines 5537 5533 -4
==========================================
- Hits 5498 5494 -4
Misses 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the
optika.distortionmodel I/O fromoptika.vectors.SceneVectorArraytona.SpectralPositionalVectorArray, so scene and sensor coordinates share a single named-arrays vector type.AbstractDistortionModel.distort/undistortnow take and returnna.SpectralPositionalVectorArray(abstract return typena.AbstractSpectralPositionalVectorArray);coordinates_sensorstaysCartesian2dVectorArray.PolynomialDistortionModel.fitfeedscoordinates_scenedirectly intoPolynomialFitFunctionArray(the scene vector already exposeswavelength/position.x/position.yas polynomial components), andundistortreturns aSpectralPositionalVectorArray.Motivation
ctis(which sits above optika, likeesis) implements the same scene→sensor forward model inctis.instruments.IdealInstrumentand already usesna.SpectralPositionalVectorArrayfor both scene and sensor coordinates. Standardizing optika's distortion model on the same named-arrays type letsctisandoptika.systems.AbstractInterpolatedSystemreuse these models without repackaging coordinates betweenSceneVectorArrayandSpectralPositionalVectorArray.Testing
pytest optika/distortion/_distortion_test.py— 26 passed (distort/undistort/round-trip, fit, andplot_residualacrossdegree∈ {1, 2}).black --checkandruff checkclean.🤖 Generated with Claude Code