Add optika.radiometry with an effective-area model#158
Merged
Conversation
Introduce the `optika.radiometry` subpackage, a home for radiometric models of an optical system. It starts with `AbstractEffectiveAreaModel` (maps wavelength -> effective area) and `InterpolatedEffectiveAreaModel`, which linearly interpolates between measured calibration points (`wavelength`, `area`). Linear interpolation is used rather than a polynomial fit because the effective area has sharp features (absorption edges, filter cutoffs, multilayer peaks) that a polynomial fits poorly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 99.31% 99.32%
=======================================
Files 114 117 +3
Lines 5722 5771 +49
=======================================
+ Hits 5683 5732 +49
Misses 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
optika.radiometry, a subpackage for radiometric models of an optical system, starting with effective area.AbstractEffectiveAreaModel— interface mapping wavelength → effective area (__call__(wavelength) -> area).InterpolatedEffectiveAreaModel— holds calibrationwavelength/areaarrays and linearly interpolates between them viana.interp.Linear interpolation (rather than a polynomial fit, as used by
optika.distortion/optika.vignetting) is deliberate: a real effective-area curve has sharp features — absorption edges, filter cutoffs, multilayer reflectivity peaks — that a polynomial fits poorly.optika.radiometryis intended as the home for the other radiometric factors of the linear forward model (energy-per-photon, voxel solid-angle/volume, etc.) as they're migrated in.Testing
pytest optika/radiometry/_effective_area_test.py— 7 passed; 100% coverage.black --checkandruff checkclean.🤖 Generated with Claude Code