Skip to content

Move the vignetting models into optika.radiometry#160

Merged
roytsmart merged 1 commit into
mainfrom
feature/vignetting-into-radiometry
Jun 1, 2026
Merged

Move the vignetting models into optika.radiometry#160
roytsmart merged 1 commit into
mainfrom
feature/vignetting-into-radiometry

Conversation

@roytsmart
Copy link
Copy Markdown
Collaborator

Summary

Folds the optika.vignetting subpackage into optika.radiometry. Vignetting (the relative field illumination) is itself a radiometric quantity, so it belongs alongside the effective-area model under one umbrella.

  • AbstractVignettingModel, AbstractInterpolatedVignettingModel, and PolynomialVignettingModel now live in and are imported from optika.radiometry.
  • The optika.vignetting subpackage is removed (and dropped from optika/__init__.py).
  • Files moved via git mv (history preserved); the docstring example and tests updated to optika.radiometry.

Breaking change

optika.vignetting.PolynomialVignettingModeloptika.radiometry.PolynomialVignettingModel (and the two abstract classes likewise).

Testing

  • pytest optika/radiometry/ — 33 passed; 100% coverage across all four radiometry files.
  • Vignetting docstring example renders headless under optika.radiometry; black --check and ruff check clean.

🤖 Generated with Claude Code

Vignetting (relative field illumination) is a radiometric quantity, so fold the
`optika.vignetting` subpackage into `optika.radiometry` alongside the
effective-area model. `AbstractVignettingModel`,
`AbstractInterpolatedVignettingModel`, and `PolynomialVignettingModel` are now
imported from `optika.radiometry`; the `optika.vignetting` subpackage is removed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.32%. Comparing base (19191f3) to head (893a9a8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   99.32%   99.32%   -0.01%     
==========================================
  Files         117      116       -1     
  Lines        5771     5769       -2     
==========================================
- Hits         5732     5730       -2     
  Misses         39       39              
Flag Coverage Δ
unittests 99.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roytsmart roytsmart merged commit 081ceb0 into main Jun 1, 2026
12 checks passed
@roytsmart roytsmart deleted the feature/vignetting-into-radiometry branch June 1, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant