Move the vignetting models into optika.radiometry#160
Merged
Conversation
Vignetting (relative field illumination) is a radiometric quantity, so fold the `optika.vignetting` subpackage into `optika.radiometry` alongside the effective-area model. `AbstractVignettingModel`, `AbstractInterpolatedVignettingModel`, and `PolynomialVignettingModel` are now imported from `optika.radiometry`; the `optika.vignetting` subpackage is removed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 99.32% 99.32% -0.01%
==========================================
Files 117 116 -1
Lines 5771 5769 -2
==========================================
- Hits 5732 5730 -2
Misses 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Folds the
optika.vignettingsubpackage intooptika.radiometry. Vignetting (the relative field illumination) is itself a radiometric quantity, so it belongs alongside the effective-area model under one umbrella.AbstractVignettingModel,AbstractInterpolatedVignettingModel, andPolynomialVignettingModelnow live in and are imported fromoptika.radiometry.optika.vignettingsubpackage is removed (and dropped fromoptika/__init__.py).git mv(history preserved); the docstring example and tests updated tooptika.radiometry.Breaking change
optika.vignetting.PolynomialVignettingModel→optika.radiometry.PolynomialVignettingModel(and the two abstract classes likewise).Testing
pytest optika/radiometry/— 33 passed; 100% coverage across all four radiometry files.optika.radiometry;black --checkandruff checkclean.🤖 Generated with Claude Code