Multiple model updates and DERSec custom models#261
Conversation
This reverts commit 7ddc692.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @altendky, @nielsbasjes on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
|
I would love to do the contributer agreement, but when I submitted it (long ago), it was rejected. |
@Kudrat9 Can we add @nielsbasjes and @altendky to the CLA list? Niels has signed. Has Kyle? |
|
I had a quick look at the new models and I spotted something that can use a bit of improvement. I see for example in model 64413 (possibly others have the same issue): I propose to make this something like this |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @altendky, @nielsbasjes on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @altendky, @nielsbasjes on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
|
My user name is @bikeshedder (note the missing It's not about shredding bikes but bikeshedding. No worries. 😆 |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @altendky, @nielsbasjes on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @altendky, @nielsbasjes on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates multiple JSON model files by adding a new "detail" property to group and unit definitions to reference documentation sections and explain special handling, and it adds a CI workflow for XML and JSON validations.
- Added "detail" properties with reference information in multiple model JSON files.
- Introduced CI pipelines for XML and JSON validation.
Reviewed Changes
Copilot reviewed 159 out of 159 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| json/model_132.json | Added "detail" with reference info to group object. |
| json/model_131.json | Added "detail" to group object with updated reference. |
| json/model_130.json | Added "detail" to unit definitions and group object with specific comments. |
| json/model_129.json | Similar "detail" additions with reference update. |
| json/model_128.json | Added "detail" to group object with multiple references. |
| json/model_127.json | Added "detail" to group object with combined references. |
| json/model_126.json | Added "detail" with reference info to group object. |
| json/model_125.json | Added "detail" to group object with revision references. |
| json/model_124.json | Added "detail" to group object with updated reference. |
| json/model_123.json | Added "detail" to group object with multiple reference sections. |
| json/model_122.json | Added "detail" to group and bitfield definitions. |
| json/model_121.json | Added "detail" to unit definitions and group object. |
| json/model_120.json | Added "detail" to unit definitions and group object with extended description. |
| json/model_113.json | Added "detail" to unit definitions. |
| json/model_112.json | Added "detail" to unit definitions. |
| json/model_111.json | Added "detail" to unit definitions. |
| json/model_103.json | Added "detail" to unit definitions. |
| json/model_102.json | Added "detail" to unit definitions. |
| json/model_101.json | Added "detail" to unit definitions. |
| .github/workflows/ci.yml | Introduced a CI pipeline for XML and JSON validation. |
Comments suppressed due to low confidence (3)
json/model_132.json:611
- Ensure that the added 'detail' field (Ref 3: 8.12.1.2) accurately reflects the current documentation specifications and remains consistent with other model files.
"type": "group",
json/model_130.json:504
- Verify that the detail message for unit 'Secs' clearly differentiates between HVRT and other control types, ensuring consistency with similar models (e.g., LVRT in model_129).
"detail": "Setting is ignored for HVRT controls."
.github/workflows/ci.yml:1
- Consider adding tests to validate the new 'detail' fields in the JSON models, ensuring they conform to expected formatting and content standards.
name: CI
No description provided.