Correct ESRmpTms standards definition.#269
Open
devunwired wants to merge 1 commit intosunspec:masterfrom
Open
Conversation
Model 703: ESRmpTms is a required IEEE 1547-2018 parameter. Correct a typo in the add_sunspec_standards.py script that was causing this parameter to be skipped and re-generate the JSON model.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @devunwired on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model 703: ESRmpTms is a required IEEE 1547-2018 parameter.
This change corrects a typo in the
add_sunspec_standards.pyscript that was causing this parameter to be skipped and re-generates the JSON model for 703.Fixes #268