Conversation
avallete
commented
Mar 25, 2025
Member
Author
avallete
left a comment
There was a problem hiding this comment.
This will need more testing on staging, and will need close monitoring on prod deploy. But should help reduce the spikes of 5xx errors we see.
| return { data: res.rows, error: null } | ||
| } catch (error: any) { | ||
| if (error instanceof DatabaseError) { | ||
| if (error.constructor.name === 'DatabaseError') { |
Member
Author
There was a problem hiding this comment.
note
With the new error propagation, had to slightly tweak this as the instanceof wasn't properly working. Even tough the constructor was the right one, the instance kept being an Error because of the promise wrapping.
Pull Request Test Coverage Report for Build 14112748589Details
💛 - Coveralls |
25bec58 to
9d831d7
Compare
soedirgo
approved these changes
Mar 27, 2025
avallete
added a commit
that referenced
this pull request
May 13, 2025
…esultsize-limit feat(server): introduce maxResultSize limit and fix pg errors handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
poolerQueryHandleErrorWith those changes the running server should be more robust, die less often and leverage killing the connections sooner than later.
Fixes PGMETA-45