Skip to content

chore(vrc): log why vrc is discarded when provisioner doesn't match a… #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkalaNetworks merged 1 commit into from
Jan 5, 2026
Merged

chore(vrc): log why vrc is discarded when provisioner doesn't match a… #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ It is possible to link multiple `StorageClass` and `VolumeReplicationClass` obje

The controller also knows that the `production-ssd-daily` `VolumeReplicationClass` can be selected using the `daily` selector.

Note that the `provisioner` of the `VolumeReplicationClass` must match the `provisioner` of the `StorageClass` it is linked to.

#### 3. Annotate your PVC or Namespace

Add the `replication.superphenix.net/classSelector` annotation to your PVC or its Namespace:
Expand Down
2 changes: 2 additions & 0 deletions internal/replicator/vrc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ func filterVrcFromSelector(group, selector, pvcProvisioner string) ([]string, er
// Allow the pvcProvisioner to be empty, as some CSI may not place it in any annotation.
if vrcProvisioner == pvcProvisioner || pvcProvisioner == "" {
classes = append(classes, item.GetName())
} else {
klog.V(2).Infof("discarded VRC %s as it doesn't have the same provisioner as the PVC, got %s, expected %s", item.GetName(), vrcProvisioner, pvcProvisioner)
}
}

Expand Down