Skip to content

Fix multiview for WebXRManager, some changes were lost in a previous rebase #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vincentfretin wants to merge 1 commit into from
Closed

Fix multiview for WebXRManager, some changes were lost in a previous rebase #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/renderers/WebGLRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@

// xr

const xr = new WebXRManager( _this, _gl );
const xr = new WebXRManager( _this, _gl, extensions, multiviewStereo );

/**
* A reference to the XR manager.
Expand Down Expand Up @@ -2657,7 +2657,7 @@

if ( ! warned ) {

console.warn( "THREE.WebGLRenderer.setTexture2D: don't use render targets as textures. Use their .texture property instead." );

Check failure on line 2660 in src/renderers/WebGLRenderer.js

View workflow job for this annotation

GitHub Actions / Lint testing 

Strings must use singlequote
warned = true;

}
Expand Down
1 change: 1 addition & 0 deletions src/renderers/webgl/WebGLTextures.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,8 @@
_gl.pixelStorei( _gl.UNPACK_SKIP_PIXELS, currentUnpackSkipPixels );
_gl.pixelStorei( _gl.UNPACK_SKIP_ROWS, currentUnpackSkipRows );

}

Check failure on line 854 in src/renderers/webgl/WebGLTextures.js

View workflow job for this annotation

GitHub Actions / Lint testing 

Block must be padded by blank lines
}

function setDeferTextureUploads( deferFlag ) {

Expand Down
Loading