Navigation, priority, control, html,comment update#267
Open
pattontim wants to merge 4 commits intosupermemo:developfrom
Open
Navigation, priority, control, html,comment update#267pattontim wants to merge 4 commits intosupermemo:developfrom
pattontim wants to merge 4 commits intosupermemo:developfrom
Conversation
Co-authored-by: kpence <kpence@tamu.edu>
Author
|
Pending comments on the more dubious changes |
pattontim
commented
Dec 19, 2022
src/Core/SuperMemoAssistant.Core/SuperMemo/Common/Elements/ElementRegistryBase.cs
Show resolved
Hide resolved
| NativeMethod.Database_AppendComment.ExecuteOnMainThread( | ||
| databasePtr, | ||
| elementId, | ||
| new DelphiUTF16String(comment)); |
Author
There was a problem hiding this comment.
is using Natives like this to insert data safe?
| [FieldOffset(60)] | ||
| /* 0x3C */ public byte unknownbyte18; | ||
| /* 0x36 */ public byte unknownbyte16; | ||
| [FieldOffset(55)] |
| { | ||
| return Core.Natives.Contents.FindText( | ||
| ContentsPtr.Read<IntPtr>(), | ||
| "test"); |
Author
There was a problem hiding this comment.
hard to implement? It's not 100% necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comment registry hooks and some hooks and methods associated with navigation, priority and HTML.
Co-authored-by: kpence kpence@tamu.edu