fix: disable memory without key#41
Conversation
There was a problem hiding this comment.
Reviewed — found 1 issue.
The silent-continue behavior is the right call for non-interactive environments (CI, headless shells) where the old browser popup would block indefinitely. However, removing startAuthFlow entirely breaks the documented re-authentication contract without providing a replacement path.
| return; | ||
| } | ||
| debugLog(settings, 'No API key found; supermemory disabled'); | ||
| writeOutput({ continue: true, suppressOutput: true }); |
There was a problem hiding this comment.
Breaking change: removes the only re-authentication path with no replacement.
startAuthFlow() is not called anywhere else in src/, and there is no /login command in plugin/commands/. This creates two concrete breakages:
-
First-time users with no env var, no project config, and no
~/.supermemory-claude/credentials.jsonwill silently get no memory — with no indication of how to set up their key beyond reading the README. -
Users who ran
/claude-supermemory:logoutare now stuck.logout.mdexplicitly tells them: "The next time a Supermemory hook runs, you'll be prompted to log in again via browser." After this change that promise is broken — the hook just silently continues with no memory and no prompt.
If the intent is to remove the auto-popup (reasonable for headless/CI environments), consider adding a /claude-supermemory:login command that explicitly triggers startAuthFlow(), and updating logout.md to point users there instead.
Summary
Verification