Skip to content

fix: disable memory without key#41

Open
Damin-Lee wants to merge 1 commit into
supermemoryai:mainfrom
Damin-Lee:fix/disable-supermemory-without-key
Open

fix: disable memory without key#41
Damin-Lee wants to merge 1 commit into
supermemoryai:mainfrom
Damin-Lee:fix/disable-supermemory-without-key

Conversation

@Damin-Lee
Copy link
Copy Markdown

Summary

  • do not launch browser auth from SessionStart when no API key is configured
  • return a silent continue response so Claude Code sessions proceed without memory context
  • rebuild plugin scripts from the source change

Verification

  • no-key SessionStart hook returns {"continue":true,"suppressOutput":true}

Copy link
Copy Markdown

@vorflux vorflux Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — found 1 issue.

The silent-continue behavior is the right call for non-interactive environments (CI, headless shells) where the old browser popup would block indefinitely. However, removing startAuthFlow entirely breaks the documented re-authentication contract without providing a replacement path.


Review with Vorflux

Comment thread src/context-hook.js
return;
}
debugLog(settings, 'No API key found; supermemory disabled');
writeOutput({ continue: true, suppressOutput: true });
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change: removes the only re-authentication path with no replacement.

startAuthFlow() is not called anywhere else in src/, and there is no /login command in plugin/commands/. This creates two concrete breakages:

  1. First-time users with no env var, no project config, and no ~/.supermemory-claude/credentials.json will silently get no memory — with no indication of how to set up their key beyond reading the README.

  2. Users who ran /claude-supermemory:logout are now stuck. logout.md explicitly tells them: "The next time a Supermemory hook runs, you'll be prompted to log in again via browser." After this change that promise is broken — the hook just silently continues with no memory and no prompt.

If the intent is to remove the auto-popup (reasonable for headless/CI environments), consider adding a /claude-supermemory:login command that explicitly triggers startAuthFlow(), and updating logout.md to point users there instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant