Skip to content

Add Singular integration attribute#481

Merged
anglinb merged 1 commit into
developfrom
codex/singular-sdid-attribute
Jun 26, 2026
Merged

Add Singular integration attribute#481
anglinb merged 1 commit into
developfrom
codex/singular-sdid-attribute

Conversation

@anglinb

@anglinb anglinb commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds singularDeviceId to IntegrationAttribute
  • Covers serialization in attribution tests
  • Adds changelog entry

Verification

  • git diff --check

Builds/tests not run per workspace preference.

@anglinb anglinb marked this pull request as ready for review June 26, 2026 20:03
@greptile-apps

greptile-apps Bot commented Jun 26, 2026

Copy link
Copy Markdown

PR author is not in the allowed authors list.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — adds a singularDeviceId (Singular SDID) attribute to the public IntegrationAttribute API.

  • Add singularDeviceId enum case — appended to IntegrationAttribute in IntegrationAttribute.swift, with the matching CustomStringConvertible arm returning "singularDeviceId". The case is added at the end of the Int-backed enum, so existing raw values stay stable and no wire format breaks.
  • Test coverageAttributionTests.swift adds .singularDeviceId to the serialization fixture and asserts storedProps["singularDeviceId"].
  • Changelog — Enhancements entry noting the new attribute.

The CustomStringConvertible switch in IntegrationAttribute.swift is the only exhaustive switch over the enum, and it's updated. Attributes are serialized to the backend by their string description, so there is no raw-value decode or persisted-ordinal path the appended case could break. Clean, minimal, and correctly tested.

Pullfrog  | View workflow run | Using Claude Opus𝕏

@anglinb anglinb merged commit 67bac96 into develop Jun 26, 2026
3 checks passed
@anglinb anglinb deleted the codex/singular-sdid-attribute branch June 26, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant