Implement private org creation with Stripe integration by gulfaniputra · Pull Request #7 · surprisetalk/ding

gulfaniputra · 2026-02-23T05:00:30Z

Summary: Implements private organization creation and management with Stripe integration at $1/member/month.

Demo: Screencast

Changes:

Database: Added org table for subscriptions and ownership.
Frontend: Added OrgCreate and OrgDashboard components.
Backend: Added Stripe Checkout flow and member management (/invite & /remove).

Integration Tests: Passed 4/4 steps (4s) using pglite and Stripe mocks (terminal output).

surprisetalk

Excellent work! The architecture is very well designed. I added some small stylistic suggestions.

surprisetalk · 2026-03-10T19:26:22Z

db.sql

+create table org (
+  name citext primary key check (name ~ '^[0-9a-zA-Z_]{4,32}$'),
+  created_by citext references usr (name) not null,
+  stripe_sub_id text,


Let's make this a unique column

Good call. I’ve added unique to stripe_sub_id. Stripe IDs are globally unique so this should be enforced at the DB level.

surprisetalk · 2026-03-10T19:27:37Z

org_test.ts

+import { PostgresConnection } from "pg-gateway";
+import dbSql from "./db.sql" with { type: "text" };
+
+const pglite = (f: (sql: pg.Sql) => (t: Deno.TestContext) => Promise<void>) => async (t: Deno.TestContext) => {


We might just want to append the org tests to server.test.ts so we don't have to copy/paste this

Makes sense. I’ve moved the org tests into server.test.ts. I’ve also added jane_doe seed and Stripe mock to the shared pglite helper.

surprisetalk · 2026-03-10T19:28:43Z

org_test.ts

+  await db.exec(`
+    insert into usr (name, email, password, bio, email_verified_at, invited_by, orgs_r, orgs_w)
+    values ('john_doe', 'john@example.com', 'hashed:password1!', 'sample bio', now(), 'john_doe', '{secret}', '{secret}')
+    on conflict do nothing;
+  `);
+
+  await db.exec(`
+    insert into usr (name, email, password, bio, email_verified_at, invited_by, orgs_r, orgs_w)
+    values ('jane_doe', 'jane@example.com', 'hashed:password1!', 'sample bio', now(), 'john_doe', '{}', '{}')
+    on conflict do nothing;
+  `);


I think you can add these to db.sql and the tests should load them automatically

Good call. I’ve moved the seed inserts into db.sql so pglite picks them up automatically via the schema load.

surprisetalk · 2026-03-10T19:31:57Z

server.tsx

+    tag: tokens.filter(t => t.startsWith("#")).map(t => t.slice(1).toLowerCase()),
+    org: tokens.filter(t => t.startsWith("*")).map(t => t.slice(1).toLowerCase()),
+    usr: tokens.filter(t => t.startsWith("@")).map(t => t.slice(1)),
+    www: tokens.filter(t => t.startsWith("~")).map(t => t.slice(1).toLowerCase()),
+    text: tokens.filter(t => !/^[#*@~]/.test(t)).join(" "),


I see a lot of formatting changes. All files should be formatted with deno fmt before commit. Double-check that prettier isn't overriding

Root cause was Prettier overriding deno fmt on save. Added .prettierignore to exclude .ts/.tsx from Prettier and .editorconfig for baseline consistency across editors.

surprisetalk · 2026-03-10T19:33:44Z

server.tsx

                return isImage
                  ? \`<a href="\${url}">\${url}</a><br><img src="\${url}" loading="lazy" style="max-width:100%;max-height:400px;">\`
                  : \`<a href="\${url}">\${url}</a>\`;


It looks like this block broke my deno fmt when I tried to run it 😅 Going to push a fix for that rn

Pulled in your fix and ran deno fmt. Formatting is clean now.

surprisetalk · 2026-03-10T19:39:15Z

server.tsx

+      insert into org (name, created_by, stripe_sub_id)
+      values (${orgName}, ${creatorName}, ${subId})


It might be easier to do this:

insert into org ${sql({ name: orgName, created_by: creatorName, stripe_sub_id: subId })}

Updated to use the sql({}) object syntax for consistency with the rest of the queries in this file.

surprisetalk · 2026-03-10T19:40:40Z

server.tsx

+    await sql`
+      update usr
+      set orgs_r = array_append(orgs_r, ${orgName}),
+          orgs_w = array_append(orgs_w, ${orgName})
+      where name = ${creatorName}


Instead of using a transaction, you can use a CTE in a single query like this:

with o as ( insert into org ... ) update usr set orgs_r = ...

Replaced the transaction with a single CTE. Cleaner and still atomic.

surprisetalk · 2026-03-10T19:43:43Z

server.tsx

+    sql`select name from usr where ${c.req.param("name")} = any(orgs_r)`,
+  ]);
+  if (!org) return notFound();
+  if (!viewerOrgs.includes(org.name)) throw new HTTPException(403, { message: "Access denied" });


Instead of fetching that viewerOrgs array, you can also do something like

select true from usr where true and name = ${c.get("name") ?? ""} and ${c.req.param("name")} = any(orgs_r)

Replaced the orgs_r array fetch with a direct select true membership check in the db.

- Add stripe to imports - Seed jane_doe in shared pglite helper - Add stripe mock to shared pglite helper - Append org management test block

- org tests moved to 'server.test.ts' - Seed data moved to 'db.sql' - No logic lost

- Prevent Prettier from overriding 'deno fmt' on .ts/.tsx files - Add baseline editor consistency across editors

- Insert into org - Update usr orgs_r & orgs_w

surprisetalk requested changes Mar 10, 2026

View reviewed changes

gulfaniputra added 6 commits March 12, 2026 14:00

Implement private org creation & management

69e8aeb

Add 'unique' constraint to 'org.stripe_sub_id'

8f7485b

Merge org tests into 'server.test.ts'

158fcfc

- Add stripe to imports - Seed jane_doe in shared pglite helper - Add stripe mock to shared pglite helper - Append org management test block

Add test seed users ('john_doe' & 'jane_doe')

fea74c5

Delete 'org_test.ts'

50761eb

- org tests moved to 'server.test.ts' - Seed data moved to 'db.sql' - No logic lost

Run ‘deno fmt’ after merging upstream fix

693b326

gulfaniputra force-pushed the create-org branch from 5cd8dd9 to 693b326 Compare March 12, 2026 06:21

gulfaniputra added 4 commits March 12, 2026 16:13

Add '.prettierignore' & '.editorconfig'

83aaec0

- Prevent Prettier from overriding 'deno fmt' on .ts/.tsx files - Add baseline editor consistency across editors

Use SQL object syntax for org insert

6b916d3

Replace transaction with single CTE

1c25fce

- Insert into org - Update usr orgs_r & orgs_w

Push org access check from JS to SQL

5a3d64a

		insert into org (name, created_by, stripe_sub_id)
		values (${orgName}, ${creatorName}, ${subId})

Conversation

gulfaniputra commented Feb 23, 2026

Uh oh!

surprisetalk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants