Skip to content

Fix custom system-messages not applied to auto-generated nav buttons #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hergie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix custom system-messages not applied to auto-generated nav buttons #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions R/config.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,12 +352,15 @@ survey_files_need_updating <- function(paths) {
return(TRUE)
}

# Re-parse if the target pages file is out of date with 'survey.qmd', 'app.R'
# Re-parse if the target pages file is out of date with 'survey.qmd', 'app.R',
# or 'settings.yml' (which contains system-messages used for nav button labels)
time_qmd <- file.info(paths$qmd)$mtime
time_app <- file.info(paths$app)$mtime
time_settings <- file.info(paths$target_settings)$mtime
time_pages <- file.info(paths$target_pages)$mtime

if ((time_qmd > time_pages) || (time_app > time_pages)) {
if ((time_qmd > time_pages) || (time_app > time_pages) ||
(time_settings > time_pages)) {
return(TRUE)
}

Expand Down Expand Up @@ -1409,8 +1412,8 @@ extract_html_pages <- function(
}

# Get translated messages
if (!is.null(settings_yaml$system_messages)) {
messages <- settings_yaml$system_messages
if (!is.null(settings_yaml$`system-messages`)) {
messages <- settings_yaml$`system-messages`
}
},
error = function(e) {
Expand Down