Add additional info in cases where Wiktionary does not have a page with useful results#107
Open
bjkeefe wants to merge 5 commits intosuyashb95:masterfrom
Open
Add additional info in cases where Wiktionary does not have a page with useful results#107bjkeefe wants to merge 5 commits intosuyashb95:masterfrom
bjkeefe wants to merge 5 commits intosuyashb95:masterfrom
Conversation
…r/driver.py, ./readme_modifications.md. Original version of core.py renamed to core.py.abo.
…patibility problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Involves several small changes to core.py, so that, when applicable, .fetch() will return information distinguishing between two cases: (1) there is no Wiktionary entry for for the default language and (2) there is no Wiktionary entry for at all.
Modifications are in a new branch named
additional_info.Details in readme_modifications.md, in the same directory as readme.md:
https://github.com/bjkeefe/WiktionaryParser/blob/additional_info/readme_modifications.md
Please note: this is my first pull request, so I apologize in advance if I haven't done some things correctly. Please feel to offer any advice. And of course, please feel free to follow up regarding the source code modifications themselves. I'm happy to make adjustments. My email address is in readme_modifications.md, if you don't see it anywhere else.
Thanks for considering!