-
-
Notifications
You must be signed in to change notification settings - Fork 59
Reworked no-navigation-without-resolve to be more general and enable more edge cases #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Reworked no-navigation-without-resolve to be more general and enable more edge cases #1444
Conversation
🦋 Changeset detectedLatest commit: d995c55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
46c1f4e to
b29463a
Compare
…to be more universal
b29463a to
acf4777
Compare
5cf7529 to
d995c55
Compare
|
Hello, I think this is ready for review now - I still want to add more edge cases (ternary expressions, function calls, array access), but those all need to build upon the structural changes introduced to this rule in this PR, so I'd prefer to merge this first and then add those as separate PRs. I'd recommend reviewing this PR commit-by-commit, as the last commit is mostly building upon the re-structured rule and shows why such a rewrite is needed... |
Fixes #1327