Skip to content

fix: add null and undefined to RemoteFormInput type #15859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PranavAgarkar07 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add null and undefined to RemoteFormInput type #15859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/blue-bears-roll.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@sveltejs/kit": patch
---

fix: add `null` to `RemoteFormInput` type to allow nullable schema validators
2 changes: 1 addition & 1 deletion packages/kit/src/exports/public.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2090,7 +2090,7 @@ type RecursiveFormFields = RemoteFormFieldContainer<any> & {
type MaybeArray<T> = T | T[];

export interface RemoteFormInput {
[key: string]: MaybeArray<string | number | boolean | File | RemoteFormInput>;
[key: string]: MaybeArray<string | number | boolean | File | null | undefined | RemoteFormInput>;
}

export interface RemoteFormIssue {
Expand Down
21 changes: 21 additions & 0 deletions packages/kit/test/types/remote.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,6 +624,27 @@ function form_tests() {
f11_field2.propA;
// @ts-expect-error
f11_field2.propB;

// schema with nullable values (e.g. Zod nullable())
const f12 = form(
null as any as StandardSchemaV1<{
nullable_string: string | null;
nested: { nullable_value: number | null };
}>,
(data) => {
data.nullable_string === '' || data.nullable_string === null;
data.nested.nullable_value === 0 || data.nested.nullable_value === null;
// @ts-expect-error
data.nonexistent;
return { success: true };
}
);
// @ts-expect-error
f12.fields.as('text');
f12.fields.nullable_string.issues();
f12.fields.nullable_string.value();
f12.fields.nested.nullable_value.issues();
f12.fields.nested.nullable_value.value();
}
form_tests();

Expand Down
2 changes: 1 addition & 1 deletion packages/kit/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2064,7 +2064,7 @@ declare module '@sveltejs/kit' {
type MaybeArray<T> = T | T[];

export interface RemoteFormInput {
[key: string]: MaybeArray<string | number | boolean | File | RemoteFormInput>;
[key: string]: MaybeArray<string | number | boolean | File | null | undefined | RemoteFormInput>;
}

export interface RemoteFormIssue {
Expand Down
Loading