Skip to content

fix: ensure base from $service-worker is available during dev #15882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teemingc wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −1
Open

fix: ensure base from $service-worker is available during dev #15882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14fc0aa
fix and changeset
teemingc May 21, 2026
00d1ca6
Merge branch 'main' into fix-service-worker-base
teemingc May 25, 2026
cc47e62
Merge branch 'main' into fix-service-worker-base
teemingc May 28, 2026
6475f37
Merge branch 'main' into fix-service-worker-base
teemingc May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/empty-hands-decide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: ensure `base` is available from `$service-worker` during development
1 change: 1 addition & 0 deletions packages/kit/src/exports/vite/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1476,6 +1476,7 @@ const create_service_worker_module = (config) => dedent`
throw new Error('This module can only be imported inside a service worker');
}

export const base = location.pathname.split('/').slice(0, -1).join('/');
Copy link
Copy Markdown
Member Author

@teemingc teemingc May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is taken from the prod version of base

kit/packages/kit/src/exports/vite/build/build_service_worker.js

Lines 41 to 42 in 14fc0aa

const base = "location.pathname.split('/').slice(0, -1).join('/')";

export const build = [];
export const files = [
${create_assets(config)
Expand Down
2 changes: 1 addition & 1 deletion packages/kit/test/apps/options-2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"prepare": "svelte-kit sync",
"check": "svelte-kit sync && tsc && svelte-check",
"test": "pnpm test:dev && pnpm test:build",
"test:dev": "DEV=true playwright test",
"test:dev": "DEV=true playwright test && REGISTER_SERVICE_WORKER=true DEV=true playwright test",
"test:build": "playwright test && REGISTER_SERVICE_WORKER=true playwright test"
},
"devDependencies": {
Expand Down
Loading