docs(adapter-node): list which env vars custom servers must implement#15914
Open
vamshikrishnaramasamy wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15734
When you set up a custom server using
handler.jsfrom@sveltejs/adapter-node, only the request-handling environment variables (e.g.ORIGIN,BODY_SIZE_LIMIT) actually do anything. The server-lifecycle ones (PORT,HOST,SOCKET_PATH, the various timeouts, and the socket-activation pair) are read byindex.js(the defaultnode buildserver) and have to be implemented manually if you want them in a custom server. The current docs don't mention this, and the existing code example hardcodes port 3000 without flagging that it's ignoringPORT.Added a note right after the custom-server code example listing both sets explicitly. Cross-checked the variable lists against the source in
packages/adapter-node/src/handler.jsandpackages/adapter-node/src/index.js.Tests
pnpm testand lint the project withpnpm lintandpnpm check. N/A — docs-only change.Changesets
Edits