Skip to content

fix: Svelte tutorial warning removals and corrections#1967

Open
michael-255 wants to merge 9 commits into
sveltejs:mainfrom
michael-255:fix/svelte-tutorial-corrections
Open

fix: Svelte tutorial warning removals and corrections#1967
michael-255 wants to merge 9 commits into
sveltejs:mainfrom
michael-255:fix/svelte-tutorial-corrections

Conversation

@michael-255
Copy link
Copy Markdown

The Svelte team has done a great job with both the tutorials and the entire docs site!

I took note of a few things to fix while working through them. There isn't a specific issue for any of these changes that I could find.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.

Changes

Added minimum needed attributes to remove the aria warnings on AudioPlayer.svelte in several tutorials.

Advanced Bindings, Dimensions:
Allow input box to be clickable if user deletes all text. This one caught me briefly.

Svelte Element:
Added a TODO comment to make it clear where the user should put the svelte:element block.
Using &amp in the instruction example so the user doesn't attempt to use <{selected}> directly which will cause this error:

Error compiling App.svelte

Expected a valid element or component name. Components must have a valid variable name or dot notation expression
https://svelte.dev/e/tag_invalid_name

@vercel
Copy link
Copy Markdown

vercel Bot commented May 9, 2026

@michael-255 is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
svelte-dev Ready Ready Preview May 28, 2026 6:13pm

{#if selected === 'h1'}
<h1>I'm a <code>&lt;h1&gt;</code> element</h1>
{:else}
<p>TODO others</p>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentional. It's to show that it wouldn't make sense to manually implement each one

@teemingc
Copy link
Copy Markdown
Member

Thanks! Do you mind splitting the different fixes into separate PRs?

class="slider"
role="slider"
aria-valuenow={time}
tabindex="0"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets rid of the warning but tabbing to it doesn't actually do anything (that I know of). Maybe it's because we don't have keyboard controls but I wonder if that might blow up the scope of the tutorial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants