fix: Svelte tutorial warning removals and corrections#1967
Open
michael-255 wants to merge 9 commits into
Open
Conversation
…s when they don't show up
|
@michael-255 is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
teemingc
reviewed
May 28, 2026
| {#if selected === 'h1'} | ||
| <h1>I'm a <code><h1></code> element</h1> | ||
| {:else} | ||
| <p>TODO others</p> |
Member
There was a problem hiding this comment.
This was intentional. It's to show that it wouldn't make sense to manually implement each one
Member
|
Thanks! Do you mind splitting the different fixes into separate PRs? |
teemingc
requested changes
May 28, 2026
teemingc
reviewed
May 28, 2026
| class="slider" | ||
| role="slider" | ||
| aria-valuenow={time} | ||
| tabindex="0" |
Member
There was a problem hiding this comment.
This gets rid of the warning but tabbing to it doesn't actually do anything (that I know of). Maybe it's because we don't have keyboard controls but I wonder if that might blow up the scope of the tutorial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Svelte team has done a great job with both the tutorials and the entire docs site!
I took note of a few things to fix while working through them. There isn't a specific issue for any of these changes that I could find.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Changes
Added minimum needed attributes to remove the aria warnings on
AudioPlayer.sveltein several tutorials.Advanced Bindings, Dimensions:
Allow input box to be clickable if user deletes all text. This one caught me briefly.
Svelte Element:
Added a TODO comment to make it clear where the user should put the
svelte:elementblock.Using
&in the instruction example so the user doesn't attempt to use<{selected}>directly which will cause this error: