fix: update REPL embed version to Svelte 5#2018
Open
Pika-pikachu30 wants to merge 1 commit into
Open
Conversation
|
@Pika-pikachu30 is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
As I just commented in the issue, shouldn't the code snippet be reverted back to Svelte 3/4 syntax instead? Full comment here: #1968 (comment) |
Author
|
I'd say that reverting to Svelte 3/4 code wouldn't be the right move becuase the decision to use Svelte 5 syntax in this blog post was already made in PR #294, which migrated examples across the site and also that PR was merged by the maintainers. thats why i think we should change here also to Svelte 5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1968
The blog post example uses Svelte 5 syntax, but the embedded REPL was loading Svelte 3 (
?version=3).This updates the embed URL to use Svelte 5 (
?version=5) so the REPL matches the example code.