fix: remove FPS-dependent spawn offsets from skill effects

[itayalroy]

Some skill effect constructors applied FPS_ANIMATION_FACTOR to spawn offsets instead of only to per-frame movement. At 60 FPS, that made effects start too low or too close to the target, so skills like Meteorite, Cometfall, Decay, etc appeared to fall faster and finish early.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a visual inconsistency in skill effects where spawn offsets were incorrectly scaled by the frame rate factor. By removing this dependency, the initial positioning of these effects is now frame-rate independent, ensuring consistent behavior across different hardware performance levels.

Highlights

• Removed FPS-dependent scaling: Removed the multiplication by FPS_ANIMATION_FACTOR from various skill effect spawn offsets to ensure consistent positioning regardless of frame rate.
• Fixed visual artifacts: Corrected issues where skill effects like Meteorite and Cometfall appeared to spawn at incorrect heights or distances at higher frame rates.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the FPS_ANIMATION_FACTOR multiplier from various object position calculations in src/source/ZzzEffect.cpp to ensure consistent movement regardless of frame rate. I have no further feedback to provide.