Fix JumpTime push movement

[itayalroy]

This PR fixes JumpTime push issues on the client:

• Stop normal hero movement processing while JumpTime is active so regular movement does not overlap with push interpolation.
• Fix PushingCharacter position update to scale by FPS_ANIMATION_FACTOR instead of adding it.
• Finalize the pushed character state cleanly at the end of the JumpTime interpolation

This fixes #303 alongside many movement quirks I encountered in-game

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses movement inconsistencies and jittering issues occurring during JumpTime push effects, particularly noticeable at higher frame rates. By refining the interpolation math and ensuring the character state is properly locked and finalized, the changes provide a smoother and more predictable movement experience.

Highlights

• Movement Logic: Disabled standard hero movement processing while JumpTime is active to prevent conflicts with push interpolation.
• Interpolation Fix: Corrected the position update calculation in PushingCharacter to use multiplicative scaling by FPS_ANIMATION_FACTOR instead of additive.
• State Finalization: Added explicit state cleanup at the end of the JumpTime interpolation to ensure character positions are accurately snapped to targets.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies the character pushing logic by adjusting the position interpolation formula and explicitly setting the final position once the jump timer exceeds a threshold. Additionally, it prevents hero movement while a jump is active. A critical bug was found where the JumpTime is not reset to zero after the push completes, which would permanently lock the character's movement due to the new check in MoveHero.

[gemini-code-assist]

The JumpTime variable is not reset to 0 after the push interpolation completes. Since a check was added in MoveHero (in ZzzInterface.cpp) to return early if JumpTime > 0, the character will be permanently unable to move after being pushed once.

You should reset c->JumpTime to 0 inside this block to allow normal movement processing to resume once the push animation is finalized.

                c->PositionX = c->TargetX;
                c->PositionY = c->TargetY;
                o->Position[0] = ((float)c->TargetX + 0.5f) * TERRAIN_SCALE;
                o->Position[1] = ((float)c->TargetY + 0.5f) * TERRAIN_SCALE;
                if (o->Type != MODEL_BALL)
                    o->Position[2] = RequestTerrainHeight(o->Position[0], o->Position[1]);

                c->JumpTime = 0;

                if (o->Type == MODEL_CRUST)
                    SetPlayerStop(c);

[itayalroy]

JumpTime is reset literally 2 lines below this comment at L3085