fix(inventory): allow dropping normal phoenix soul items

[olisikh]

Problem:
Normal Phoenix Soul set items can't be dropped once picked up, they are treated as "special", as "lucky set items".
Index of Phoenix Soul items is 73, which is effectively 11 + 62, as seen in the code.

Effect:

• Lucky Set items are still correctly restricted: indices 62-72 (11 indexes)
• Phoenix Soul Armor, Helmet, Pants, Boots and Star (all index 73) are not treated as expensive and can be dropped now.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the inventory management logic to resolve an issue where Phoenix Soul set items were incorrectly categorized as restricted 'Lucky Set' items. By adjusting the iteration range in the item action check, the change ensures that Phoenix Soul gear can now be dropped by players as intended, while maintaining the necessary restrictions for actual Lucky Set items.

Highlights

• Inventory Logic Adjustment: Updated the loop range in Check_ItemAction to correctly distinguish between Lucky Set items and Phoenix Soul items.
• Item Dropping Capability: Enabled dropping for Phoenix Soul items by excluding index 73 from the restricted 'expensive' item category.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates a loop boundary in ZzzInventory.cpp, changing the iteration count from 12 to 11 when setting item action options. The review feedback suggests replacing this magic number with a named constant to enhance code maintainability and readability.