fix(ancient): show purple/blue glow aura when wearing full ancient set

[olisikh]

Fix ancient set glowing aura when wearing a full set

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a visual bug where the purple glow aura for characters wearing a full ancient set was not displaying correctly. The changes ensure that the game client accurately reflects the ancient set's complete status, providing proper visual feedback to players when the full set is equipped.

Highlights

• Ancient Set Aura Logic: Implemented explicit handling for the ancient full-set glow state (purple aura) in WSclient.cpp, ensuring the ExtendState is correctly set based on whether the ancient set is complete.
• Animation Frame Rate Adjustment: Simplified the ExtendStateTime increment in ZzzCharacter.cpp from a frame rate-dependent calculation to a simple increment, potentially affecting animation timing or consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request implements explicit updates for the ancient full-set glow state during player changes and simplifies the increment logic for the state timer. Feedback was provided regarding the direct assignment to ExtendState, which may inadvertently clear other flags if the variable is used as a bitfield, along with a suggestion to rename the variable for improved clarity.