Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/containers/filter.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default class FilterContainer extends React.Component {
{filter === false ? null :
<div className="filter-container">
<Col className="filter wrapper" mobile={12}>
<input className={classNames.join(" ")} placeholder="Filter by tag" type="text"
<input className={classNames.join(" ")} aria-label="Filter by tag" placeholder="Filter by tag" type="text"
onChange={this.onFilterChange} value={typeof filter === "string" ? filter : ""}
disabled={isLoading}/>
</Col>
Expand Down
17 changes: 17 additions & 0 deletions test/e2e-cypress/e2e/a11y/filter-input.cy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
describe("Filter input accessibility", () => {
describe("with filter enabled", () => {
it("should expose an accessible name via aria-label on the filter input", () => {
cy.visit("/?url=/documents/petstore.swagger.yaml&filter=true")
.get(".operation-filter-input")
.should("exist")
.should("have.attr", "aria-label", "Filter by tag")
})

it("should still render the visual placeholder for sighted users", () => {
cy.visit("/?url=/documents/petstore.swagger.yaml&filter=true")
.get(".operation-filter-input")
.should("exist")
.should("have.attr", "placeholder", "Filter by tag")
})
})
})
16 changes: 16 additions & 0 deletions test/unit/components/filter.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,20 @@ describe("<FilterContainer/>", function(){
const renderedColInsideFilter = wrapper.find(Col)
expect(renderedColInsideFilter.length).toEqual(0)
})

it("exposes an accessible name on the filter input via aria-label", function(){

// Given
let props = {...mockedProps}
props.layoutSelectors = {...mockedProps.specSelectors}
props.layoutSelectors.currentFilter = function() {return true}

// When
let wrapper = mount(<FilterContainer {...props}/>)

// Then
const input = wrapper.find("input.operation-filter-input")
expect(input.length).toEqual(1)
expect(input.prop("aria-label")).toEqual("Filter by tag")
})
})