Open
Conversation
ubogdan
reviewed
Oct 21, 2024
| func main() { | ||
| r := http.NewServeMux() | ||
|
|
||
| r.Handle("GET /swagger/", httpSwagger.Handler( |
Contributor
There was a problem hiding this comment.
Did you test the r.Handle route ? Looks to me like invalid according to the documentation
import (
"fmt"
"net/http"
)
type apiHandler struct{}
func (apiHandler) ServeHTTP(http.ResponseWriter, *http.Request) {}
func main() {
mux := http.NewServeMux()
mux.Handle("/api/", apiHandler{})
mux.HandleFunc("/", func(w http.ResponseWriter, req *http.Request) {
// The "/" pattern matches everything, so we need to check
// that we're at the root here.
if req.URL.Path != "/" {
http.NotFound(w, req)
return
}
fmt.Fprintf(w, "Welcome to the home page!")
})
}
Contributor
|
I want this example to work with (1.19 or newer). |
These are the new routing enhancements launched announce with Go 1.22 in February 2024. I think it's a good idea to include this as an example in the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
I added an example that allows generating and displaying Swagger documentation using http.NewServeMux
Relation issue
e.g. https://github.com/swaggo/gin-swagger/pull/123/files
Additional context
The Go version must be 1.22 or higher to be able to use all the new features.