Skip to content

[lldb] Allow LLDBMemoryReader to provide symbols outside refl. sections #11954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrian-prantl merged 2 commits into from
Dec 12, 2025
Merged

[lldb] Allow LLDBMemoryReader to provide symbols outside refl. sections #11954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b156756
[lldb] Allow LLDBMemoryReader to provide symbols outside refl. sections
augusto2112 Dec 6, 2025
841e53e
[lldb] Disable LLDBMemoryReader::resolvePointerAsSymbol on Linux
augusto2112 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions lldb/source/Plugins/LanguageRuntime/Swift/LLDBMemoryReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,14 @@ LLDBMemoryReader::resolvePointerAsSymbol(swift::remote::RemoteAddress address) {
if (!target.GetSwiftUseReflectionSymbols())
return {};

auto &triple = m_process.GetTarget().GetArchitecture().GetTriple();
// On Linux, there seems to be a bug where we can't reliably look for symbols by address,
// since these symbols have an actual size and can overlap.
// This could be an LLDB bug or a compiler bug.
// rdar://166344740
if (triple.isOSLinux())
return {};

std::optional<Address> maybeAddr = remoteAddressToLLDBAddress(address);
// This is not an assert, but should never happen.
if (!maybeAddr)
Expand All @@ -195,19 +203,6 @@ LLDBMemoryReader::resolvePointerAsSymbol(swift::remote::RemoteAddress address) {
return {};
}

if (auto section_sp = addr.GetSection()) {
if (auto *obj_file = section_sp->GetObjectFile()) {
auto obj_file_format_type =
obj_file->GetArchitecture().GetTriple().getObjectFormat();
if (auto swift_obj_file_format =
GetSwiftObjectFileFormat(obj_file_format_type)) {
if (!swift_obj_file_format->sectionContainsReflectionData(
section_sp->GetName().GetStringRef()))
return {};
}
}
}

if (auto *symbol = addr.CalculateSymbolContextSymbol()) {
auto mangledName = symbol->GetMangled().GetMangledName().GetStringRef();
// MemoryReader requires this to be a Swift symbol. LLDB can also be
Expand Down