🍒[llvm][cas] Improve UnifiedOnDiskActionCache validation to check cas refs #11981
+57
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refs (llvm#171732) Check that action cache references point to valid CAS objects by ensuring they are contained within the corresponding CAS and also that the offsets match. This prevents accidentally referencing "dead" index records that were not properly flushed to disk, which can lead to the action cache pointing to the wrong data or to garbage data. rdar://126642956 (cherry picked from commit a451ff0)
benlangmuir
commented
Dec 11, 2025
|
|
||
| // FIXME: on newer branches we have refactored getIndexProxyFromRef to return | ||
| // Expected<IndexProxy>. As a stop gap, provide a checked API. | ||
| Expected<IndexProxy> getIndexProxyFromRefChecked(InternalRef Ref) const; |
Author
There was a problem hiding this comment.
@cachemeifyoucan review note: I introduced this and used it from getObjectPresence to workaround the differences in Error-handling between main and stable/21.x.
Author
|
@swift-ci please test llvm |
Author
|
@swift-ci please test |
cachemeifyoucan
approved these changes
Dec 11, 2025
Author
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that action cache references point to valid CAS objects by ensuring they are contained within the corresponding CAS and also that the offsets match. This prevents accidentally referencing "dead" index records that were not properly flushed to disk, which can lead to the action cache pointing to the wrong data or to garbage data.
rdar://126642956
(cherry picked from commit a451ff0)