Add support for a declaration attribute @warn for source-level warning group behavior control
#85036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
efeb7d8 to
f2090a1
Compare
artemcm
changed the title
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
2 times, most recently
from
b5ce4d2 to
f166258
Compare
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
4 times, most recently
from
f346cd4 to
213b207
Compare
artemcm
requested review from
CodaFi,
DougGregor,
bnbarham,
hamishknight,
hborla,
rintaro,
slavapestov,
tshortli,
xedin and
xymus
as code owners
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
2 times, most recently
from
09ccd1f to
b22b692
Compare
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
b22b692 to
693aeae
Compare
Contributor
Author
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
693aeae to
72a0e52
Compare
Contributor
Author
artemcm
changed the title
@warn for source-level warning group behavior control
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
72a0e52 to
8019c96
Compare
Contributor
Author
|
@swift-ci test Linux platform |
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
9ac4a7f to
e2f23c1
Compare
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
e2f23c1 to
340f38b
Compare
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
2 times, most recently
from
40beea2 to
ef00dd8
Compare
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
ef00dd8 to
aa1be67
Compare
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
aa1be67 to
7b269d3
Compare
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
7b269d3 to
fefa937
Compare
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
fefa937 to
5e5cbeb
Compare
Contributor
Author
|
@swift-ci test |
xymus
reviewed
Dec 12, 2025
xymus
reviewed
Dec 12, 2025
xymus
reviewed
Dec 12, 2025
xymus
approved these changes
Dec 12, 2025
Contributor
xymus
left a comment
xymus
left a comment
There was a problem hiding this comment.
I think the change to RestrictNonProductionExperimentalFeatures needs to be dropped, besides that this LGTM!
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
5e5cbeb to
88c04bf
Compare
…ing group behavior control
…nostic Unified across module-wide configuration flags (`-Wwarning`, `-Werror`, etc.) and syntactic configuration attribute `@warn`.
…y attribute argument parsing Otherwise these source file objects linger in the source manager but they refer to a fully-temporary 'ASTContext' which does not exist after parsing is complete, which means they cannot be used in any way and attempting to do so would lead to a crash.
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
88c04bf to
0a4d352
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes/commits:
Add parsing for an experimental declaration attribute '@warn' for source-level warning group behavior control. This attribute is gated behind an experimental feature
SourceWarningControl.Implement support for unified warning group behavior queries per-diagnostic-group:
-Wwarningand-Werrorflags, as well asDefaultIgnorediagnostic groups to be captured as aWarningGroupBehaviorRule(as opposed to a priorWarningAsErrorRule) and replace the corresponding diagnostic group ID-indexed bit vectors inDiagnosticEnginewith with a dictionary keyed by the diagnostic group ID with values representing behavior specification rules (such asAsError,AsWarning,Ignored).SwiftWarningControlSwiftSyntax library for a given warning diagnostic's diagnostic group's emission behavior at the diagnostic's source location, as determined by syntactic@warncontrols. (Implemented inASTGen/WarningGroupBehaviorConfiguration.swift).SwiftWarningControlquery as global control inputs. This means the same query will take into account both global warning control rules specified on the command-line, as well as source-location-specific containing@warnattribute controls.ExportedSourceFile, the first query ofwarningGroupBehaviorAtPositionwill result in construction of aWarningControlRegionTreedata-structure which will be cached in theExportedSourceFileit belongs to and re-used for future queries.