[DeepClone] Test deepclone of tidyNode (final internal class without serialization API)#563
Closed
GromNaN wants to merge 2 commits into
Closed
[DeepClone] Test deepclone of tidyNode (final internal class without serialization API)#563GromNaN wants to merge 2 commits into
GromNaN wants to merge 2 commits into
Conversation
nicolas-grekas
force-pushed
the
deepclone
branch
from
7d79c09 to
35d7cf1
Compare
…serialization API)
GromNaN
force-pushed
the
deepclone-tidy-test
branch
from
b3362ec to
c7b2ba6
Compare
Member
|
Thanks, merged as 35d7cf1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tidyNodeis a final internal PHP class (bundledtidyextension) with a C-level constructor but no__serialize/__unserialize/__sleep/__wakeup. It was incorrectly rejected by the polyfill as not instantiable.This PR adds a test covering this class as the PHP-only counterpart of the PHPT test added in symfony/php-ext-deepclone#5.