fix: keychain access persistence #326
Open
+775
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a security issue where sensitive keychain data (mnemonics, passphrases, PINs) persisted after app uninstall on iOS. The solution implements a Documents directory marker file to reliably detect app reinstallation and automatically wipes orphaned keychain data.
Changes:
- Implemented installation marker mechanism using Documents directory for reliable reinstall detection
- Added automatic detection and cleanup of orphaned native and React Native keychain data
- Enhanced keychain security attributes to prevent iCloud sync and restrict to device-only access
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Bitkit/Utilities/InstallationMarker.swift | New utility for managing installation marker file in Documents directory |
| Bitkit/Utilities/Keychain.swift | Updated security attributes to use device-only access and disable synchronization |
| Bitkit/Services/MigrationsService.swift | Added orphaned RN keychain detection and comprehensive cleanup methods |
| Bitkit/AppScene.swift | Integrated orphaned keychain handling at app startup |
| Bitkit/Utilities/AppReset.swift | Added marker deletion during app reset |
| BitkitTests/InstallationMarkerTests.swift | Comprehensive tests for installation marker functionality |
| BitkitTests/OrphanedKeychainTests.swift | Tests for orphaned keychain detection and cleanup |
| BitkitTests/RNMigrationCleanupTests.swift | Tests for RN migration cleanup functionality |
| BitkitTests/KeychainTests.swift | Enhanced tests to verify security attributes and device-only access |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pwltr
reviewed
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #293
Description
This PR prevents sensitive keychain data (mnemonics, passphrases, PINs) from being recovered after app uninstall by:
This only affects the upgrade path. Normal usage after installation and migration from RN works correctly.
Why Documents Marker?
The Keychain data is stored in App Group storage, which persists after uninstall on iOS. The Documents directory is reliably deleted on uninstall, so the marker file serves as the reliable detection mechanism.
Testing Scenarios
Screenshot / Video
unninstall-master-install-rn-migrate.mp4
install-over-master.mp4
reset-and-restore.mp4
delete-and-restore.mp4
recover-from.RN.mp4