Fix commit hook breakage #220
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Mar 3, 2025
Contributor
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Don't mention the number of pull request. Instead, refer to the short commit hash.
jserv
reviewed
Mar 3, 2025
jserv
reviewed
Mar 3, 2025
Dennis40816
force-pushed
the
unify_commit_msg_lines
branch
from
7aaeed1 to
82cc680
Compare
jserv
requested changes
Mar 3, 2025
Contributor
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Check the suspicious commit 4a8d8b5 : unknown revision or path not in the working tree.
The functionality introduced in commit d39d920 was broken due to changes introduced in commit 4a8b8d5, where some occurrences of 'COMMIT_MSG_LINES' were replaced with 'commit_msg_lines' without updating all relevant functions. This commit fixes the issue by replacing all instances of 'commit_msg_lines' with 'COMMIT_MSG_LINES', ensuring consistency and restoring the intended functionality. Change-Id: I0c93617be83c5f24b1e17678566883c0481ddc48
Dennis40816
force-pushed
the
unify_commit_msg_lines
branch
from
82cc680 to
ff5e2b7
Compare
Contributor
Author
The typo in the commit was fixed. |
Contributor
|
Thank @Dennis40816 for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality introduced in d39d920 was broken due to changes introduced in commit 4a8b8d5, where some occurrences of
COMMIT_MSG_LINESwere replaced withcommit_msg_lineswithout updating all relevant functions.This PR fixes the issue by replacing all instances of
COMMIT_MSG_LINESwithcommit_msg_lines.