fix: prevent subscription cycles when adding subscriptions #8083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
nickgerace
previously approved these changes
Dec 18, 2025
| let prototype_id = AttributePrototypeArgument::prototype_id(ctx, apa_id).await?; | ||
| for av_id in AttributePrototype::attribute_value_ids(ctx, prototype_id).await? { | ||
| let subscriber_component_id = AttributeValue::component_id(ctx, av_id).await?; | ||
| // Don't add self-subscriptions |
nickgerace
reviewed
Dec 18, 2025
| ) | ||
| .await?; | ||
|
|
||
| assert_eq!(false, SubscriptionGraph::new(ctx).await?.is_cyclic()); |
Contributor
There was a problem hiding this comment.
Suggested change
| assert_eq!(false, SubscriptionGraph::new(ctx).await?.is_cyclic()); | |
| assert!(!SubscriptionGraph::new(ctx).await?.is_cyclic()); |
Contributor
Author
There was a problem hiding this comment.
the two ! right next to each other don't make me happy :(
nickgerace
dismissed
their stale review
Accidentally hit "approve" instead of "comment"!
zacharyhamm
force-pushed
the
fix/subs
branch
2 times, most recently
from
38c031e to
29d389e
Compare
Contributor
Author
|
There's a weird error here with attribute prototype arguments not having prototypes which gets hit when constructing the graph. Investigating |
zacharyhamm
force-pushed
the
fix/subs
branch
2 times, most recently
from
378d8be to
0716a89
Compare
zacharyhamm
force-pushed
the
fix/subs
branch
from
0716a89 to
bc2d21d
Compare
Contributor
Author
|
/try |
|
Okay, starting a try! I'll update this comment once it's running... |
zacharyhamm
force-pushed
the
fix/subs
branch
from
bc2d21d to
5f53fb9
Compare
zacharyhamm
force-pushed
the
fix/subs
branch
from
5f53fb9 to
cd0bf0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construct a DependencyGraph of all components via their ValueSubscription edges and use that to detect subscription cycles when a subscription is set.
How to test this: create a bunch of subscriptions. Try to create a cycle, see that it fails. See that normal subscriptions don't fail.
Note: once this deploys, any graph that currently has subscription cycles will no longer be able to have new subscriptions.