refactor(mdb): use SQLExecDirect for infer_schema (simpler than prepare+execute)#89
Merged
Merged
Conversation
…_schema mdbtools does not support SQL_ATTR_PARAMSET_SIZE so odbc-api's safe conn.execute() fails with HY092. Use SQLExecDirect directly (one ODBC call instead of two: prepare + execute). Metadata is collected from the cursor after exec_direct.
…pattern Replace the manual preallocate + unsafe exec_direct + unsafe CursorImpl with odbc-api's safe conn.execute(&sql, (), None). This is the same pattern used by the DM connection — zero unsafe blocks.
lewiszlw
force-pushed
the
refactor/mdb-infer-schema-safe-prepare
branch
from
b15231b to
060f5d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the
prepare+executetwo-step approach inMdbConnection::infer_schemawith a singleSQLExecDirectcall — matching the pattern already used in the query/table-listing paths.Rationale
SQLExecDirectis one ODBC call instead of two (prepare + execute)SQLPreparefor one-off schema queries — exec_direct returns the result set immediatelySQL_ATTR_PARAMSET_SIZElimitation only blocks odbc-api's safeconn.execute()wrapper; manualexec_directworks fineChanges
mod.rs: usepreallocate → exec_direct → CursorImplin infer_schemaschema.rs: revertbuild_remote_schemato acceptCursorImpl<StatementImpl>(needed by exec_direct cursor)