refactor(mdb): remove dummy bind_col workaround in query#91
Merged
Conversation
The dummy column bind was a workaround for mdbtools 1.0.x which required SQLBindCol before SQLFetch. With odbc-api's safe conn.execute() wrapper handling the statement lifecycle, try removing this workaround to see if mdbtools no longer hangs on SQLFetch without prior SQLBindCol.
lewiszlw
force-pushed
the
refactor/mdb-query-safe-exec
branch
from
c7f8833 to
62b1cab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
移除 MDB query 路径中的 dummy bind_col 绕过方案（22 行删除）。
mdbtools 1.0.x 要求 SQLFetch 之前必须先 SQLBindCol，否则挂起。在使用 odbc-api 的 safe
conn.execute()之后，尝试直接调用cursor.next_row()，验证 mdbtools 是否仍需要此绕过。conn.execute()内部可能已做处理，或者新版 mdbtools 修复了此问题。