This repository was archived by the owner on Nov 21, 2021. It is now read-only.
Patch for drum() module to work around an openscad bug in how difference() works on Mac and Linux#8
Open
jprorama wants to merge 1 commit intosyvwlch:masterfrom
Open
Patch for drum() module to work around an openscad bug in how difference() works on Mac and Linux#8jprorama wants to merge 1 commit intosyvwlch:masterfrom
jprorama wants to merge 1 commit intosyvwlch:masterfrom
Conversation
There is an inconsistency in openscad in how difference works on Macs and Linux. When the drumHeight is 0, i.e. escapementWheel(), then the first term in the difference() for the drum() module will be empty. This causes the Mac to treat the second term as the actual object and render it. This leaves an artifact on the escapement wheel that is a solid disk which must be drilled out manually to recover the axis hole for the escapement wheel. On linux platforms this artifact doesn't appear. For an openscad example that demonstrates the problem see: openscad/openscad#221
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an inconsistency in openscad in how difference works on Macs and Linux.
When the drumHeight is 0, i.e. escapementWheel(), then the first term in the difference() for
the drum() module will be empty. This causes the Mac to treat the second term as the actual
object and render it. This leaves an artifact on the escapement wheel that is a solid disk which must
be drilled out manually to recover the axis hole for the escapement wheel. On linux platforms this
artifact doesn't appear.
For an openscad example that demonstrates the problem see:
openscad/openscad#221