@W-21748754: Add tools for retrieving data and images for custom views by anyoung-tableau · Pull Request #285 · tableau/tableau-mcp

anyoung-tableau · 2026-03-31T20:51:10Z

No description provided.

…e' into anyoung/custom-views

Copilot

Pull request overview

This PR adds support for retrieving Tableau Custom View data (CSV) and images (PNG) via new MCP tools, including authorization gating and docs/tests updates.

Changes:

Added new MCP tools: get-custom-view-data and get-custom-view-image, plus OAuth scope mapping and tool registry wiring.
Extended bounded-context authorization to support custom views by resolving to the underlying published view (ResourceAccessChecker.isCustomViewAllowed).
Updated test fixtures and added/updated e2e + oauth tests and documentation for the new tools.

Reviewed changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/oauth/tableau-authz/tests/listWorkbooks.test.ts	Adjusts workbook assertions to align with updated fixture shape.
tests/oauth/tableau-authz/tests/getWorkbook.test.ts	Adjusts workbook assertions to align with updated fixture shape.
tests/oauth/tableau-authz/tests/getViewImage.test.ts	Updates view id lookup to use `defaultView.id`.
tests/oauth/tableau-authz/tests/getViewData.test.ts	Updates view id lookup to use `defaultView.id`.
tests/oauth/tableau-authz/tests/getCustomViewImage.test.ts	Adds authz test for custom view image tool.
tests/oauth/tableau-authz/tests/getCustomViewData.test.ts	Adds authz test for custom view data tool.
tests/e2e/workbooks/listWorkbooks.test.ts	Updates workbook assertions to use `defaultView.id`.
tests/e2e/workbooks/getWorkbook.test.ts	Updates workbook assertions to use `defaultView.id`.
tests/e2e/views/listViews.test.ts	Updates view id comparisons to use `defaultView.id`.
tests/e2e/views/getViewImage.test.ts	Updates tool args to use `defaultView.id`.
tests/e2e/views/getViewData.test.ts	Updates tool args to use `defaultView.id`.
tests/e2e/views/getCustomViewImage.test.ts	Adds e2e test coverage for custom view image retrieval.
tests/e2e/views/getCustomViewData.test.ts	Adds e2e test coverage for custom view data retrieval.
tests/constants.ts	Updates Superstore workbook fixture to include `defaultView: { id, customViewId }`.
src/tools/views/mockCustomView.ts	Adds mock `CustomView` fixture for unit tests.
src/tools/views/getViewImage.test.ts	Fixes PNG binary/base64 handling in unit tests (latin1/base64).
src/tools/views/getCustomViewImage.ts	Implements `get-custom-view-image` MCP tool.
src/tools/views/getCustomViewImage.test.ts	Adds unit tests for `get-custom-view-image`.
src/tools/views/getCustomViewData.ts	Implements `get-custom-view-data` MCP tool.
src/tools/views/getCustomViewData.test.ts	Adds unit tests for `get-custom-view-data`.
src/tools/tools.ts	Registers new tools in the tool factory list.
src/tools/toolName.ts	Adds new tool names and includes them in the `view` tool group.
src/tools/resourceAccessChecker.ts	Adds custom view authorization via underlying published view resolution + caching.
src/tools/resourceAccessChecker.test.ts	Adds test coverage for `isCustomViewAllowed`.
src/tools/convertPngDataToToolResult.ts	Ensures PNG base64 encoding preserves bytes via `latin1`.
src/server/oauth/scopes.ts	Adds OAuth scope requirements for the new tools.
src/sdks/tableau/types/customView.ts	Adds `CustomView` type/schema for REST responses.
src/sdks/tableau/methods/viewsMethods.ts	Adds REST methods: getCustomView, getCustomViewData, getCustomViewImage.
src/sdks/tableau/apis/viewsApi.ts	Adds REST endpoints: getCustomView, getCustomViewData, getCustomViewImage.
src/errors/mcpToolError.ts	Adds `CustomViewNotAllowedError` (403).
mcp.docker.cursor.example.json	Adds Cursor docker MCP server example config.
docs/docs/tools/views/get-custom-view-image.md	Adds documentation for `get-custom-view-image`.
docs/docs/tools/views/get-custom-view-data.md	Adds documentation for `get-custom-view-data`.
docs/docs/intro.md	Updates tool list and references to include the new tools.
.cursor/rules/tableau-mcp.mdc	Updates internal tool registry count/list for Cursor rules.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/e2e/views/getCustomViewData.test.ts

tests/e2e/views/getCustomViewImage.test.ts

src/sdks/tableau/apis/viewsApi.ts

anyoung-tableau · 2026-04-01T00:45:47Z

src/tools/views/getViewData.ts

+  viewFilters: z
+    .record(z.string())
+    .optional()
+    .describe('Optional map of view filter field names to values.'),


Driveby updates to get-view-data and get-view-image tools to include the view filters to be in sync with the Custom View tools.

anyoung-tableau · 2026-04-01T00:46:50Z

src/restApiInstance.ts

+  if (response.params && Object.keys(response.params).length > 0) {
+    url.search = new URLSearchParams(response.params).toString();


Driveby fix here. This was wrong before and the query params weren't included in the response traces.

anyoung-tableau · 2026-04-01T00:48:12Z

src/sdks/tableau/interceptors.ts

 ): Omit<ResponseInterceptorConfig, 'baseUrl'> {
  return {
    url: response.config.url ?? 'UNKNOWN URL',
+    params: response.config.params,


Driveby fix here to ensure the response interceptor includes the URL search params in the trace.

anyoung-tableau · 2026-04-07T16:41:39Z

docs/docs/configuration/tableau-config.md

 # Configuring Tableau

-Tableau MCP works with both Tableau Server and Tableau Cloud data with these prerequisites:
+Tableau MCP works with both Tableau Server 2024.2+ and Tableau Cloud data with these prerequisites:


I added the min Server version here because the Get Custom View Image REST API was only added in 2023.1 and someone trying to use it against an older Server version would see errors. 2024.2 is a min bar anyway (mostly driven by VDS compatibility)

niraj-desai-sf and others added 11 commits March 19, 2026 12:12

Loading custom view image via MCP as per the documentation

ae90129

Merge remote-tracking branch 'niraj-desai-sf/loading-custom-view-imag…

a6c133e

…e' into anyoung/custom-views

Add custom view REST API methods

b5ac6ed

Merge remote-tracking branch 'origin/main' into anyoung/custom-views

11b172a

Fix merge errors

43c7cf9

Infer generic type

35fcf99

Fix tests and lint

6c099a9

Add custom view field

2cb5f47

Update tests

72ce273

Add OAuth tests

c71d053

Merge remote-tracking branch 'origin/main' into anyoung/custom-views

db8b471

Copilot AI review requested due to automatic review settings March 31, 2026 20:51

salesforce-cla bot added the cla:signed label Mar 31, 2026

Copilot started reviewing on behalf of anyoung-tableau March 31, 2026 20:51 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

tests/e2e/views/getCustomViewData.test.ts Outdated Show resolved Hide resolved

tests/e2e/views/getCustomViewImage.test.ts Outdated Show resolved Hide resolved

src/sdks/tableau/apis/viewsApi.ts Show resolved Hide resolved

src/sdks/tableau/apis/viewsApi.ts Show resolved Hide resolved

anyoung-tableau added 4 commits March 31, 2026 14:26

Various cleanup

1b34a36

Add min Tableau version

1c61b77

Fix E2E test

9e3249d

More clean up and bug fixing

d00fb4e

anyoung-tableau commented Apr 1, 2026

View reviewed changes

anyoung-tableau marked this pull request as draft April 1, 2026 20:35

anyoung-tableau mentioned this pull request Apr 3, 2026

Loading custom view image via MCP as per the documentation #272

Closed

11 tasks

anyoung-tableau added 3 commits April 7, 2026 08:15

Merge remote-tracking branch 'origin/main' into anyoung/custom-views

1a86f66

Add format

e8e7291

Add getImageFormatForVersion

0677c33

anyoung-tableau commented Apr 7, 2026

View reviewed changes

anyoung-tableau added 2 commits April 7, 2026 11:34

Self review

67f3868

[in progress] Add list-custom-views tool

fe9edd4

anyoung-tableau added 2 commits April 8, 2026 09:49

Remove import

8aefe48

Require workbookId

5639463

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@W-21748754: Add tools for retrieving data and images for custom views#285

@W-21748754: Add tools for retrieving data and images for custom views#285
anyoung-tableau wants to merge 22 commits intomainfrom
anyoung/custom-views

anyoung-tableau commented Mar 31, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anyoung-tableau Apr 1, 2026

Uh oh!

anyoung-tableau Apr 1, 2026

Uh oh!

anyoung-tableau Apr 1, 2026

Uh oh!

anyoung-tableau Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		if (response.params && Object.keys(response.params).length > 0) {
		url.search = new URLSearchParams(response.params).toString();

Conversation

anyoung-tableau commented Mar 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anyoung-tableau Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

anyoung-tableau Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

anyoung-tableau Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

anyoung-tableau Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants