fix: eliminate O(n) lag on rectangular selection in large tables#4899
Open
KrzysztofDusko wants to merge 1 commit into
Open
fix: eliminate O(n) lag on rectangular selection in large tables#4899KrzysztofDusko wants to merge 1 commit into
KrzysztofDusko wants to merge 1 commit into
Conversation
…+ rows) Rectangular selection via mouse drag caused severe lag proportional to scroll position. At the bottom of a 50k-row table, each mousemove event triggered three O(n) operations making selection unusable. Root causes and fixes: 1. RowManager.getRowFromPosition() used .find() scanning from index 0, reaching O(n) for rows near the bottom. Replaced with O(1) direct array access displayRows[position - 1] with .find() fallback for grouped-row edge cases. 2. SelectRange.getTableRows() created a new filtered array copy on every call. Added _tableRowsCache with invalidation in resetRanges() and tableDestroyed(). 3. handleCellMouseMove / handleColumnMouseMove had no throttling, causing the full layout pipeline (getActiveCell -> getCell x 2 per range -> range.layout) to execute on every mouse event (~120/sec). Wrapped in requestAnimationFrame to cap at one layout per frame. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
KrzysztofDusko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rectangular selection via mouse drag caused severe lag proportional to scroll position. At the bottom of a 50k-row table, each mousemove event triggered three O(n) operations making selection unusable.
Root causes and fixes:
RowManager.getRowFromPosition() used .find() scanning from index 0, reaching O(n) for rows near the bottom. Replaced with O(1) direct array access displayRows[position - 1] with .find() fallback for grouped-row edge cases.
SelectRange.getTableRows() created a new filtered array copy on every call. Added _tableRowsCache with invalidation in resetRanges() and tableDestroyed().
handleCellMouseMove / handleColumnMouseMove had no throttling, causing the full layout pipeline (getActiveCell -> getCell x 2 per range -> range.layout) to execute on every mouse event (~120/sec). Wrapped in requestAnimationFrame to cap at one layout per frame.