perf(sort): precompute sort keys and fast-path numeric sorter#4906
Draft
lukecotter wants to merge 1 commit into
Draft
perf(sort): precompute sort keys and fast-path numeric sorter#4906lukecotter wants to merge 1 commit into
lukecotter wants to merge 1 commit into
Conversation
_sortItems decorates each row with its sort keys and component once, sorts the decorated array, then writes rows back, instead of re-deriving values inside every comparison. The number sorter returns a-b directly for finite numbers, skipping String()/split. Adds Sort._sortItems and number-sorter unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Speed up multi-row sorting without changing ordering semantics.
Changes
_sortItems: decorate each row with its sort keys and component once, sort the decorated array, then write the rows back (decorate-sort-undecorate). Stock re-derivedgetData()/getFieldValue()/getComponent()inside every comparison (O(n log n) calls); this does it O(n) up front. Implemented with a positional array (aMapkeyed by row was measurably slower).a - bdirectly when both values are finite numbers, skippingString()/ separator splitting /parseFloat.Benchmarks (Node, 250k rows)
Tests
Adds
_sortItemscorrectness tests (multi-column asc/desc, stability, and equality vs a reference implementation over 50 randomized trials) plus number-sorter cases. Full suite green; ordering identical to before.