perf(datatree): cache module refs and flatten child recursion#4908
Draft
lukecotter wants to merge 1 commit into
Draft
perf(datatree): cache module refs and flatten child recursion#4908lukecotter wants to merge 1 commit into
lukecotter wants to merge 1 commit into
Conversation
Cache filter/sort module references and options at initialize. getChildren recurses into a single shared accumulator (_collectChildren) so each descendant is pushed once, instead of allocating and re-copying an array at every level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce allocation in data-tree child traversal. Behaviour-preserving.
Changes
dataTreeFilter/dataTreeSortoption flags atinitialize()instead of re-resolving them on every traversal.getChildrenrecurses into a single shared accumulator (_collectChildren) so each descendant is pushed exactly once, instead of allocating and re-copying an array at every level of the tree.Benchmark (Node)
getChildrenover ~250k tree nodes (depth 4, fanout 6): +38% (1.6×)Tests
Full unit suite green;
DataTreespec updated to reflect that module references are now read at initialize time (realistic mock table).