866: FeatureFlag annotation by alfardil · Pull Request #878 · tahminator/codebloom

alfardil · 2026-03-29T23:59:59Z

866 Description of changes

Added an annotation to use @ff

Checklist before review

I have done a thorough self-review of the PR
Copilot has reviewed my latest changes, and all comments have been fixed and/or closed.
If I have made database changes, I have made sure I followed all the db repo rules listed in the wiki here. (check if no db changes)
All tests have passed
I have successfully deployed this PR to staging
I have done manual QA in both dev (and staging if possible) and attached screenshots below.

Screenshots

Dev

User metrics false in application.yml

User metrics true in application.yml

Staging

github-actions · 2026-03-30T00:00:25Z

Available PR Commands

/ai - Triggers all AI review commands at once
/review - AI review of the PR changes
/describe - AI-powered description of the PR
/improve - AI-powered suggestions
/deploy - Deploy to staging

See: https://github.com/tahminator/codebloom/wiki/CI-Commands

github-actions · 2026-03-30T00:00:29Z

PR Description Required

Please fill out the Description of changes section of the PR.

github-actions · 2026-03-30T00:00:58Z

PR Description Required

Please fill out the Description of changes section of the PR.

github-actions · 2026-03-30T00:02:31Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Dynamic Flag Management The `getAllFlags()` method currently hardcodes the mapping of feature flag names to their boolean values. As the number of feature flags grows, this method will require frequent manual updates. Consider if a more dynamic or declarative approach for registering and retrieving feature flags would be beneficial for future scalability and maintainability. public Map<String, Boolean> getAllFlags() { return Map.of( "duels", ff.isDuels(), "userMetrics", ff.isUserMetrics()); SpEL Expression Efficiency The `gateMethodByFeatureFlags` method modifies the SpEL expression string by replacing flag names with prefixed variables (`#flagName`) in a loop. While functional, this string manipulation could be less efficient for complex expressions or a large number of flags. SpEL's `StandardEvaluationContext` allows setting variables directly, which might offer a more performant way to evaluate expressions without modifying the original string. for (String flagName : flags.keySet()) { parsedExpression = parsedExpression.replaceAll("(?<!#)\\b" + Pattern.quote(flagName) + "\\b", "#" + flagName);

src/main/java/org/patinanetwork/codebloom/common/ff/FeatureFlagManager.java

src/main/java/org/patinanetwork/codebloom/common/ff/FFAspect.java

github-actions · 2026-03-30T00:18:21Z

PR Description Required

Please fill out the Description of changes section of the PR.

github-actions · 2026-03-30T00:19:37Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review SpEL Expression Robustness The `FFAspect` modifies the SpEL expression string by prefixing identified feature flag names with `#`. While this allows for simpler annotation values, string manipulation on expressions can be fragile. There's a risk of unintended replacements or issues with more complex SpEL syntax or edge-case flag names. Consider if requiring the `#` prefix in the `@FF` annotation value (e.g., `@FF("#duels && #userMetrics")`) or using a root object in the `StandardEvaluationContext` (e.g., `@FF("flags.duels && flags.userMetrics")`) would offer a more robust and maintainable approach. for (String flagName : flags.keySet()) { parsedExpression = parsedExpression.replaceAll("(?<!#)\\b" + Pattern.quote(flagName) + "\\b", "#" + flagName);

src/main/java/org/patinanetwork/codebloom/common/ff/FeatureFlagManager.java

src/main/java/org/patinanetwork/codebloom/common/ff/FFAspect.java

github-actions · 2026-03-30T00:28:36Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review SpEL Performance The SpEL expression is parsed on every invocation of an annotated method. While `SpelExpressionParser` might have internal caching, for extremely high-throughput endpoints, explicitly caching the parsed `Expression` objects for unique `@FF` expressions could be a minor optimization to consider if performance becomes a concern. isEnabled = parser.parseExpression(expression).getValue(context, Boolean.class); Reflection Robustness The `initializeFlags` method uses reflection to find "is" methods. While this is a common pattern for configuration objects, ensure that `FeatureFlagConfiguration` will only contain simple boolean getters and no other methods that could inadvertently be invoked or cause issues during reflection. The current implementation correctly filters by return type and parameter count, which is good. Map<String, Boolean> flags = new HashMap<>(); for (Method method : ff.getClass().getMethods()) { if (method.getName().startsWith("is") && method.getReturnType() == boolean.class && method.getParameterCount() == 0) { try { String flagName = Introspector.decapitalize(method.getName().substring(2)); flags.put(flagName, (Boolean) method.invoke(ff)); } catch (Exception e) { throw new IllegalStateException( "Failed to resolve feature flag value from method: " + method.getName(), e); } }

src/main/java/org/patinanetwork/codebloom/common/ff/FeatureFlagManager.java

github-actions · 2026-03-30T00:35:55Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review SpEL Expression Parsing The logic for transforming feature flag names in the expression by prefixing them with '#' using `replaceAll` is critical. While the use of `Pattern.quote` and word boundaries (`\b`) helps, it's important to ensure this transformation is robust against all possible valid flag names and complex SpEL expressions, preventing unintended replacements or performance issues with a large number of flags or very long expressions. String parsedExpression = expression; for (String flagName : flags.keySet()) { parsedExpression = parsedExpression.replaceAll("(?<!#)\\b" + Pattern.quote(flagName) + "\\b", "#" + flagName); }

src/main/java/org/patinanetwork/codebloom/common/ff/FFAspect.java

github-actions · 2026-03-30T16:56:35Z

Failed to generate code suggestions for PR

github-actions · 2026-03-30T17:21:07Z

Failed to generate code suggestions for PR

github-actions · 2026-03-30T17:54:14Z

Failed to generate code suggestions for PR

github-actions · 2026-03-31T03:14:33Z

Failed to generate code suggestions for PR

alfardil · 2026-03-31T03:18:27Z

/ai

github-actions · 2026-03-31T03:19:24Z

Failed to generate code suggestions for PR

tahminator · 2026-03-31T03:19:44Z

/review

tahminator · 2026-03-31T03:19:45Z

/describe

tahminator · 2026-03-31T03:19:45Z

/improve

github-actions · 2026-03-31T03:21:13Z

Preparing PR description...

github-actions · 2026-03-31T03:21:15Z

Preparing review...

github-actions · 2026-03-31T03:22:35Z

Failed to generate code suggestions for PR

src/main/java/org/patinanetwork/codebloom/common/ff/FeatureFlagManager.java

github-actions · 2026-03-31T19:31:09Z

Failed to generate code suggestions for PR

alfardil · 2026-03-31T20:21:42Z

/deploy

github-actions · 2026-03-31T20:23:00Z

Failed to generate code suggestions for PR

github-actions · 2026-03-31T20:36:45Z

Failed to generate code suggestions for PR

alfardil · 2026-03-31T20:36:58Z

/deploy

github-actions · 2026-03-31T20:38:43Z

Failed to generate code suggestions for PR

tahminator · 2026-04-01T00:05:20Z

/deploy

tahminator · 2026-04-01T00:05:36Z

/copy

github-actions · 2026-04-01T01:12:15Z

Failed to generate code suggestions for PR

github-actions · 2026-04-01T01:54:50Z

Failed to generate code suggestions for PR

github-actions · 2026-04-01T18:13:27Z

Failed to generate code suggestions for PR

github-actions · 2026-04-01T23:37:43Z

Failed to generate code suggestions for PR

Arshadul-Monir · 2026-04-01T23:53:01Z

/deploy

github-actions · 2026-04-01T23:54:27Z

Failed to generate code suggestions for PR

Tests passed

alfardil force-pushed the 866 branch from d4f0de7 to 30b051d Compare March 30, 2026 00:00

github-actions bot reviewed Mar 30, 2026

View reviewed changes

src/main/java/org/patinanetwork/codebloom/common/ff/FeatureFlagManager.java Outdated Show resolved Hide resolved

src/main/java/org/patinanetwork/codebloom/common/ff/FFAspect.java Show resolved Hide resolved

alfardil force-pushed the 866 branch from 223b19b to 67e5ab4 Compare March 30, 2026 00:17

github-actions bot reviewed Mar 30, 2026

View reviewed changes

src/main/java/org/patinanetwork/codebloom/common/ff/FeatureFlagManager.java Show resolved Hide resolved

github-actions bot reviewed Mar 30, 2026

View reviewed changes

src/main/java/org/patinanetwork/codebloom/common/ff/FFAspect.java Show resolved Hide resolved

alfardil force-pushed the 866 branch from a3f0c8f to efacfcb Compare March 30, 2026 17:19

alfardil force-pushed the 866 branch from 65bb689 to df46084 Compare March 31, 2026 03:13

alfardil force-pushed the 866 branch from a0b84ca to 4cd1b79 Compare March 31, 2026 03:21

tahminator previously requested changes Mar 31, 2026

View reviewed changes

src/main/java/org/patinanetwork/codebloom/common/ff/FeatureFlagManager.java Outdated Show resolved Hide resolved

alfardil force-pushed the 866 branch from 4cd1b79 to 813cee5 Compare March 31, 2026 19:29

alfardil force-pushed the 866 branch from bac9501 to cf171ff Compare March 31, 2026 20:36

Arshadul-Monir force-pushed the 866 branch from baa8433 to fbf2f28 Compare April 1, 2026 18:11

Arshadul-Monir force-pushed the 866 branch from fbf2f28 to 8228ece Compare April 1, 2026 23:35

alfardil and others added 4 commits April 1, 2026 19:52

866: FeatureFlag annotation

26d64ab

866: Migrated controllers to use FF

16818d4

866: Added javadoc

f3fee5e

866: TestProtector fix

df6b358

Arshadul-Monir force-pushed the 866 branch from 8228ece to df6b358 Compare April 1, 2026 23:52

Arshadul-Monir enabled auto-merge (rebase) April 2, 2026 01:53

Arshadul-Monir approved these changes Apr 2, 2026

View reviewed changes

Arshadul-Monir merged commit 9234f28 into main Apr 2, 2026
72 of 80 checks passed

Arshadul-Monir deleted the 866 branch April 2, 2026 01:55

Conversation

alfardil commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

866

Description of changes

Checklist before review

Screenshots

Dev

Staging

Uh oh!

github-actions bot commented Mar 30, 2026

Available PR Commands

Uh oh!

github-actions bot commented Mar 30, 2026

PR Description Required

Uh oh!

github-actions bot commented Mar 30, 2026

PR Description Required

Uh oh!

github-actions bot commented Mar 30, 2026

PR Reviewer Guide 🔍

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2026

PR Description Required

Uh oh!

github-actions bot commented Mar 30, 2026

PR Reviewer Guide 🔍

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2026

PR Reviewer Guide 🔍

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2026

PR Reviewer Guide 🔍

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

alfardil commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

tahminator commented Mar 31, 2026

Uh oh!

tahminator commented Mar 31, 2026

Uh oh!

tahminator commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

alfardil commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

alfardil commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

tahminator commented Apr 1, 2026

Uh oh!

alfardil commented Mar 29, 2026 •

edited

Loading